Repository navigation
chore(deps): override @azure/msal-node to 7.1.0 in the VS Code extension's dev tree - #515
Merged
Merged
Conversation
…ion's dev tree The patched release for GHSA-xcx6-jx8p-x3h5 is 7.1.0. Releases from 5.0.0-beta.0 up to but not including 7.1.0 are affected. In vscode/, @azure/msal-node is reached only through @azure/identity, which @vscode/vsce depends on. Both are development dependencies, and the extension has no runtime dependencies. @azure/identity declares @azure/msal-node ^6.0.0, which excludes 7.x, so a plain update cannot reach 7.1.0. The npm override is the lockfile-level fix. Checked with npm ci, npm run lint, npm test and npm run package: the packaged VSIX contains no node_modules, so the override does not reach the extension at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
@azure/msal-nodeto 7.1.0 in the VS Code extension's development tree with anoverridesentry, which closes the open Dependabot alert on the lockfile (GHSA-xcx6-jx8p-x3h5).@azure/identitydeclares@azure/msal-node^6.0.0, which excludes 7.x, so a plain bump cannot reach the patched version. The package reaches the tree only through@vscode/vsceand@azure/identity; the packaged extension does not include it.Test plan
npm ci,npm run lint,npm test(33) invscode/npm run packagebuilds the VSIX (43 files, nonode_modules)🤖 Generated with Claude Code