Repository navigation
Start Celery worker through /bin/sh like Flower and scheduler - #232
Merged
Merged
Conversation
On SELinux-enforcing hosts systemd refused to execute the celery binary from the venv in the user's home directory ('Failed to locate executable ... Permission denied', status 203/EXEC), which broke alts-celery on the s390x node. Start it via /bin/sh -c 'exec ...', the same way alts-flower and alts-scheduler start their home venv binaries, so no SELinux relabelling is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alts-celeryfails to start on the s390x node (SELinux enforcing):This is the same failure fixed for Flower in efb35a3: systemd won't execute a binary from a venv in the user's home directory directly under SELinux.
alts-schedulerandalts-floweralready start through/bin/sh -c 'exec ...';alts-celerywas the remaining unit that didn't. It likely surfaced now because theupdatetag (85bbd04) re-runs the pip install, which rewritesbin/celerywith the default home-directory label (not confirmed on the host).Changes
deployment/templates/alts-celery.service.j2: wrapExecStartin/bin/sh -c 'exec ...'. Withexec, celery replaces the shell and stays the unit's main process.ExecStartPreis unchanged.Testing
docker-s390x-0queue,/home/test-system/.venv-celery) and ransystemd-analyze verifyon it: no errors.celery_playbook.ymlwith--tags updateon the s390x node and checksystemctl status alts-celery.🤖 Generated with Claude Code