Repository navigation
Add cryptography build deps for s390x build nodes - #51
Merged
Merged
Conversation
On s390x cryptography is built from sdist with --no-build-isolation, so its maturin backend and cffi>=2 must be preinstalled in the venv. Also install libffi-devel for building cffi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build node env setup on s390x fails at
Install requirements into virtualenvwithBackendUnavailable: Cannot import 'maturin'.google-auth(pulled viaimmudb-py) depends oncryptography, which has no s390x wheel, so pip builds the sdist. On s390x requirements are installed with--no-build-isolation, so the build backend must already be present in the venv.Changes
roles/separate_build_node/defaults/main/common.yml: addmaturin>=1.9.4,<2andcffi>=2.0.0tobuild_node_s390x_build_requirements(system cffi is 1.14 and is visible via--system-site-packages)roles/separate_build_node/defaults/main/dnf.yml: addlibffi-develtobuild_node_s390x_dnf_packagesfor building cffiTesting
albs-s3-builder-alma-08/09)