Skip to content

feat(options): notebooks folder moves now; reset follows the build - #361

Merged
DWAA1660 merged 3 commits into
mainfrom
feat/notebooks-folder-live/agent-2
Nov 17, 2026
Merged

DWAA1660 merged 3 commits into
mainfrom
feat/notebooks-folder-live/agent-2

Conversation

@mameen

@mameen mameen commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Changing the notebooks folder moves the window to it at once and remembers it. Previously it only applied after a restart, so the window kept showing the old notebooks.
  • The folder chooser opens in the current notebooks folder, not in Documents.
  • Use the default folder goes back to the folder this build starts with: my-notebooks in a debug build, and Documents\NoteCraft in production. The development folder is read only in a debug build.
  • Fixes a clippy warning in the folder chooser.

Refs #356.

Testing

  • cargo xtask pre-push passed on 9ded3e4 (full cargo xtask ci, PII check, branch check).
  • Regression tests added: after_a_change_the_window_lists_the_notebooks_in_the_new_folder (ui-egui), choosing_a_notebooks_folder_moves_to_it_now (ui-egui), a_debug_build_never_resets_to_the_production_folder (store), plus changing_the_root_shows_the_notebooks_in_the_new_folder (engine).
  • Not covered by a test: the folder chooser's starting folder. It is a native dialog and cannot be driven from a test, so it still needs a manual check.
  • The new tests were not run against the old code, so I have not confirmed they fail there.

🤖 Generated with Claude Code

alientechsw and others added 3 commits November 17, 2026 15:02
Changing the folder moves the window to it at once and remembers it. Use the default folder goes back to the folder this build starts with: the development folder in a debug build, and Documents\NoteCraft in production. The development folder is read only in a debug build. Also restores the doc comment above set_ui_scale.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The dialog now starts in the notebooks folder NoteCraft uses now, instead of Documents.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The window lists the notebooks in a newly chosen folder at once, and a debug build never resets to the production folder. Also fixes a clippy warning in the folder chooser.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>

@alientechsw alientechsw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fixed !

@DWAA1660
DWAA1660 merged commit eaae868 into main Nov 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants