Repository navigation
feat(options): notebooks folder moves now; reset follows the build - #361
Merged
Merged
Conversation
Changing the folder moves the window to it at once and remembers it. Use the default folder goes back to the folder this build starts with: the development folder in a debug build, and Documents\NoteCraft in production. The development folder is read only in a debug build. Also restores the doc comment above set_ui_scale. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The dialog now starts in the notebooks folder NoteCraft uses now, instead of Documents. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The window lists the notebooks in a newly chosen folder at once, and a debug build never resets to the production folder. Also fixes a clippy warning in the folder chooser. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
my-notebooksin a debug build, andDocuments\NoteCraftin production. The development folder is read only in a debug build.Refs #356.
Testing
cargo xtask pre-pushpassed on9ded3e4(fullcargo xtask ci, PII check, branch check).after_a_change_the_window_lists_the_notebooks_in_the_new_folder(ui-egui),choosing_a_notebooks_folder_moves_to_it_now(ui-egui),a_debug_build_never_resets_to_the_production_folder(store), pluschanging_the_root_shows_the_notebooks_in_the_new_folder(engine).🤖 Generated with Claude Code