Repository navigation
[PWGCF,PWGLF] Add Sigma+ via PCM reco to Femto framework - #18510
Merged
romainschotter merged 3 commits intoOct 30, 2026
Merged
Conversation
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
hfribert
marked this pull request as ready for review
October 29, 2026 20:47
hfribert
requested review from
HorstMa,
abmodak,
alibuild,
ariedel-cern,
dimihayl,
dmallick2,
dsarkaralice,
ercolessi,
gbencedi,
lauraser,
lhusova,
maciacco,
mario-krueger,
mpuccio,
omvazque,
prottayCMT,
romainschotter,
skundu692,
smaff92,
victor-gonzalez and
wrzesaCERN
as code owners
October 29, 2026 20:47
romainschotter
previously approved these changes
Oct 29, 2026
Collaborator
|
Error while checking build/O2Physics/code-check for dee81e9 at 2026-10-30 03:19: Full log here. |
| } | ||
| if (mProduceSigmaPlusPcmExtras) { | ||
| kinkProducts.producedSigmaPlusPcmExtras( | ||
| sigmaPlusPcm.mlScore(), |
Collaborator
There was a problem hiding this comment.
The ML score should be stored in a seperate table. Like this it can be easily used for selections in a pair task or similiar
| o2::framework::Preslice<FemtoSigmaPlusExtended> perColSigmaPlusExtended = o2::aod::femtobase::stored::fColId; | ||
|
|
||
| kinkbuilder::ConfSigmaPlusPcmSelection1 sigmaPlusPcmSelection1; | ||
| o2::framework::Partition<FemtoSigmaPlusPcm> sigmaPlusPcmPartition = MAKE_SIGMAPLUSPCM_PARTITION(sigmaPlusPcmSelection1); |
Collaborator
There was a problem hiding this comment.
Paritions cut on the ML score will come in a later update, I assume?
hfribert
marked this pull request as draft
October 30, 2026 09:25
added 3 commits
October 30, 2026 15:30
…nd pair task, MC labels via the proton for background
hfribert
force-pushed
the
sigma-plus-pcm-femto
branch
from
October 30, 2026 14:33
dee81e9 to
27e64a4
Compare
hfribert
marked this pull request as ready for review
October 30, 2026 14:50
ariedel-cern
approved these changes
Oct 30, 2026
romainschotter
approved these changes
Oct 30, 2026
Collaborator
|
Error while checking build/O2Physics/code-check for 27e64a4 at 2026-10-30 17:34: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
as MlScore in LFKinkDecayTables, together with index columns (collision, proton, photon legs, McParticle in MC)
needed by the Femto framework. New proton/photon DCAz-to-PV cuts photon DCAz cut applied before pairing and
tighter default tilt to reduce CPU