Repository navigation
[PWGDQ] add event level histograms in same-event-pairing - #18489
Merged
Merged
Conversation
…-preserving-mepm-rotated-legs
ayatsujiringo
requested review from
XiaozhiBai,
alibuild,
axti98,
glegras,
iarsene,
lucamicheletti93,
mguilbau and
shreyasiacharya
as code owners
October 28, 2026 09:43
|
O2 linter results: ❌ 0 errors, |
axti98
requested changes
Oct 28, 2026
axti98
left a comment
axti98
left a comment
Collaborator
There was a problem hiding this comment.
Hi, thanks for handling this issue.
Just one remark, such that it is not forgotten:
At the moment in "processSkimmedAll" the histograms are filled twice, since the pairing function there is called twice. This seems to apply also to the "PairingSEQA" histograms. For now, I would keep it like this for but we have to think about how to handle the split collisions better.
axti98
approved these changes
Oct 29, 2026
axti98
enabled auto-merge (squash)
October 29, 2026 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because the rejection of the split collision is applied and select events in same-event-pairing but not in event selection, so I add a new histogram class to fix it, use it when you turn on the cfgRemoveCollSplittingCandidates