Skip to content

[PWGCF] validation for new version flowPtContainer - #18484

Closed
Luzhiyongg wants to merge 4 commits into
AliceO2Group:masterfrom
Luzhiyongg:master
Closed

[PWGCF] validation for new version flowPtContainer#18484
Luzhiyongg wants to merge 4 commits into
AliceO2Group:masterfrom
Luzhiyongg:master

Conversation

@Luzhiyongg

@Luzhiyongg Luzhiyongg commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Oct 28, 2026
@github-actions github-actions Bot changed the title validation for new version flowPtContainer [PWGCF] validation for new version flowPtContainer Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 6 warnings, 🔕 5 disabled

@alibuild alibuild mentioned this pull request Oct 28, 2026
Merged
@Luzhiyongg
Merge pull request #34 from alibuild/alibot-cleanup-18484
a74e87d 
[PWGCF] Please consider the following formatting changes to AliceO2Group#18484
@alibuild

alibuild commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7d61cbe at 2026-10-28 02:39:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 191 warnings.'
Found 1 errors and 191 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/4b285bb174fc660d3f33a39a43c7971254749ec0/O2Physics-code-check/errors.txt
PWGCF/Flow/Tasks/flowTask.cxx:1157:9: error: Branch condition evaluates to a garbage value [clang-analyzer-core.uninitialized.Branch,-warnings-as-errors]
++ [[ 191 -gt 0 ]]
++ cat /sw/BUILD/4b285bb174fc660d3f33a39a43c7971254749ec0/O2Physics-code-check/warnings.txt
PWGCF/Flow/Tasks/flowTask.cxx:82:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/Flow/Tasks/flowTask.cxx:83:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:84:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:86:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/Flow/Tasks/flowTask.cxx:101:66: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:103:67: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:374:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:469:22: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:489:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/flowTask.cxx:496:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:498:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:500:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:506:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:513:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:520:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:536:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:548:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:662:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:662:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:665:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:665:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:677:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:679:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:703:53: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:714:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:724:111: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/flowTask.cxx:729:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:731:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:734:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:745:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:747:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:750:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:752:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a74e87d at 2026-10-28 02:58:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 191 warnings.'
Found 1 errors and 191 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/f0745af516e942d2bf177eeefc2878835ade4aac/O2Physics-code-check/errors.txt
PWGCF/Flow/Tasks/flowTask.cxx:1157:9: error: Branch condition evaluates to a garbage value [clang-analyzer-core.uninitialized.Branch,-warnings-as-errors]
++ [[ 191 -gt 0 ]]
++ cat /sw/BUILD/f0745af516e942d2bf177eeefc2878835ade4aac/O2Physics-code-check/warnings.txt
PWGCF/Flow/Tasks/flowTask.cxx:82:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/Flow/Tasks/flowTask.cxx:83:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:84:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:86:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/Flow/Tasks/flowTask.cxx:101:66: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:103:67: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:374:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:469:22: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:489:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/flowTask.cxx:496:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:498:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:500:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:506:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:513:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:520:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:536:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:548:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:662:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:662:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:665:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:665:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:677:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:679:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:703:53: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:714:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:724:111: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/flowTask.cxx:729:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:731:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:734:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:745:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:747:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:750:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:752:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 28dc7f1 at 2026-10-28 03:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 195 warnings.'
Found 1 errors and 195 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/338c8e96d801e2f1fe9e243f97eaec3ceb4c11a9/O2Physics-code-check/errors.txt
PWGCF/Flow/Tasks/flowTask.cxx:1157:9: error: Branch condition evaluates to a garbage value [clang-analyzer-core.uninitialized.Branch,-warnings-as-errors]
++ [[ 195 -gt 0 ]]
++ cat /sw/BUILD/338c8e96d801e2f1fe9e243f97eaec3ceb4c11a9/O2Physics-code-check/warnings.txt
PWGCF/Flow/Tasks/flowTask.cxx:82:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/Flow/Tasks/flowTask.cxx:83:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:84:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:86:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/Flow/Tasks/flowTask.cxx:101:66: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:103:67: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:374:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:469:22: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:489:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/flowTask.cxx:496:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:498:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:500:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:506:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:513:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:520:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:536:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:548:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:662:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:662:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:665:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:665:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:677:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:679:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:703:53: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:714:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:724:111: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/flowTask.cxx:729:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:731:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:734:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:745:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:747:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:750:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:752:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
[0 more errors; see full log]

Full log here.

@Luzhiyongg Luzhiyongg closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@majanik majanik Awaiting requested review from majanik majanik is a code owner
@EmilGorm EmilGorm Awaiting requested review from EmilGorm EmilGorm is a code owner
@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner
@wenyaCern wenyaCern Awaiting requested review from wenyaCern wenyaCern is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@dsarkaralice dsarkaralice Awaiting requested review from dsarkaralice dsarkaralice is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Luzhiyongg @alibuild