Skip to content

[PWGCF] Modified the Efficiency and the Purity correction. - #17841

Merged
dsarkaralice merged 10 commits into
AliceO2Group:masterfrom
S10GPhysics:master
Sep 10, 2026
Merged

[PWGCF] Modified the Efficiency and the Purity correction.#17841
dsarkaralice merged 10 commits into
AliceO2Group:masterfrom
S10GPhysics:master

Conversation

@S10GPhysics

@S10GPhysics S10GPhysics commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

S10GPhysics and others added 9 commits August 9, 2026 17:26
@S10GPhysics
Enhance PID QA and histogram configurations
c892d44 
Added PID response configurations and QA histograms for TPC and TOF. Updated multiplicity and centrality axes for histograms.
@S10GPhysics
Merge branch 'AliceO2Group:master' into master
4900ab2
@S10GPhysics
Enhance longrangecorrDerived with MC axes and processing
d917217 
Added new configurable axes for MC particle properties and updated histogram definitions to include these axes. Introduced new processing functions for V0 and mixed events.
@S10GPhysics
Merge branch 'AliceO2Group:master' into master
b2e0c9a
@S10GPhysics
Enhance V0 selection and add new histograms
389601e 
Added new configurable parameters for V0 selection and updated the processV0QA function to include additional histogram filling for V0 candidates. Enhanced selection criteria for K0s and Lambda candidates with PID cuts.
@S10GPhysics
Fix variable initialization and update multiplicity calculation
f49cf35
@S10GPhysics
Merge branch 'AliceO2Group:master' into master
60dcb5f
@S10GPhysics
Merge branch 'AliceO2Group:master' into master
a8b8892
@S10GPhysics
Enhance PID configurations and update identification logic
1369d8b 
Added configurable parameters for TPC and TOF n-sigma cuts to clean templates. Updated particle identification logic to use new n-sigma configurations.
@github-actions github-actions Bot added the pwgcf label Sep 9, 2026
@github-actions github-actions Bot changed the title Modified the Efficiency and the Purity correction. [PWGCF] Modified the Efficiency and the Purity correction. Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 3 disabled

@dsarkaralice
dsarkaralice enabled auto-merge (squash) September 9, 2026 12:21
dsarkaralice
dsarkaralice previously approved these changes Sep 9, 2026
View reviewed changes
@alibuild

alibuild commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 1369d8b at 2026-09-09 14:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 65 warnings.'
Found 4 errors and 65 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/8802dc882d292958b935e0669a32c2926327668e/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:72:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:301:41: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:302:38: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:518:24: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 65 -gt 0 ]]
++ cat /sw/BUILD/8802dc882d292958b935e0669a32c2926327668e/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:346:48: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:354:48: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:399:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:401:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:403:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:405:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:409:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:411:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:413:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:415:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:417:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:419:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:421:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:507:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:524:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:528:123: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:531:118: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:536:79: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:538:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:572:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:576:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:578:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:614:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:616:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:641:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:643:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:693:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:695:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:708:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:711:43: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:713:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:715:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:715:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:1071:21: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:1073:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:1075:64: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@S10GPhysics
Refactor service initialization and type casting
137ac0c 
Updated service initialization and type casting for track filter parameters.
auto-merge was automatically disabled September 9, 2026 13:27

Head branch was pushed to by a user without write access

@dsarkaralice
dsarkaralice enabled auto-merge (squash) September 9, 2026 18:30
@dsarkaralice
dsarkaralice merged commit aec9c5b into AliceO2Group:master Sep 10, 2026
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenyaCern wenyaCern wenyaCern approved these changes
@dsarkaralice dsarkaralice dsarkaralice left review comments
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@S10GPhysics @alibuild @wenyaCern @dsarkaralice