[Infrastructure,Tools,Common,Tutorial,PWGDQ,PWGHF,PWGLF] [WIP] [ML] Fix for memory issue in ML headers - #17836
Open
ChSonnabend wants to merge 3 commits into
Open
[Infrastructure,Tools,Common,Tutorial,PWGDQ,PWGHF,PWGLF] [WIP] [ML] Fix for memory issue in ML headers#17836ChSonnabend wants to merge 3 commits into
ChSonnabend wants to merge 3 commits into
Conversation
ChSonnabend
requested review from
NicoleBastid,
XiaozhiBai,
alibuild,
apalasciano,
deepathoms,
ercolessi,
fcatalan92,
fcolamar,
fgrosa,
fmazzasc,
gluparel,
hahassan7,
iarsene,
jpxrk,
lhusova,
mcoquet642,
mfaggin,
mguilbau,
mmazzilli,
mpuccio,
omvazque,
romainschotter,
singhra1994,
skundu692,
stefanopolitano,
vkucera,
xinyepeng and
zhangbiao-phy
as code owners
September 8, 2026 18:24
ChSonnabend
requested review from
a team,
ddobrigk,
dsekihat,
jgrosseo and
ktf
as code owners
September 8, 2026 18:24
|
O2 linter results: ❌ 357 errors, |
Contributor
Author
|
This still needs to be tested but should fix a memory issue spotted by @mhemmer-cern and discussed with @fmazzasc |
Collaborator
|
Error while checking build/O2Physics/o2 for be8a4a7 at 2026-09-08 20:34: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for be8a4a7 at 2026-09-08 20:45: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for be8a4a7 at 2026-09-08 21:04: Full log here. |
romainschotter
previously approved these changes
Sep 8, 2026
Collaborator
|
Error while checking build/O2Physics/code-check for a31fa89 at 2026-09-08 23:05: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the dangling float* pointers and replaces it with a std::vector allocation.