Skip to content

[PWGHF] Fix a typo in the selector - #17828

Open
JaeYoonCHO wants to merge 2 commits into
AliceO2Group:masterfrom
JaeYoonCHO:fixSelectorTypo
Open

[PWGHF] Fix a typo in the selector#17828
JaeYoonCHO wants to merge 2 commits into
AliceO2Group:masterfrom
JaeYoonCHO:fixSelectorTypo

Conversation

@JaeYoonCHO

Copy link
Copy Markdown
Contributor

This PR fixes a typo in candidateSelectorXicToXiPiPi.cxx, where the isSelectedTrackItsQuality check was originally applied only to the first pion. After this fix, isSelectedTrackItsQuality is applied to both pions.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix a typo in the selector [PWGHF] Fix a typo in the selector Sep 8, 2026
@alibuild

alibuild commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 60b4843 at 2026-09-08 12:25:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 7 errors and 3 warnings.'
Found 7 errors and 3 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/28396500d0456bdc84e7a605478a733d545ac1d7/O2Physics-code-check/errors.txt
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:57:52: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:85:56: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:607:32: error: variable 'statusPidPi0' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:608:32: error: variable 'statusPidPi1' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:609:32: error: variable 'statusPidPiXi' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:610:32: error: variable 'statusPidPrLam' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:611:32: error: variable 'statusPidPiLam' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/28396500d0456bdc84e7a605478a733d545ac1d7/O2Physics-code-check/warnings.txt
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:124:10: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:124:26: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:145:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants