[PWGCF] Run 3 Magnetic Field Path and configurable added

[nmallick19]

Magnetic field is needed for the two track cut to work
Magnetic field is cached per run, so repeated calls are now avoided per timestamp
Assuming that magnetic field does not change for a given run number

[github-actions]

O2 linter results: ❌ 3 errors, ⚠️ 6 warnings, 🔕 0 disabled

[vkucera]

@nmallick19 Please specify the location of the changes in the PR title.

[nmallick19]

@vkucera Hi! The code is in [PWGCF], this is added already. Sorry, I did not follow which location do I have to add here?

[vkucera]

@vkucera Hi! The code is in [PWGCF], this is added already. Sorry, I did not follow which location do I have to add here?

Please read the contribution guidelines.

[nmallick19]

Sorry, I am confused here. The locations of the changes made to the file cannot be put in the title itself, there are too many changes, and therefore, we have the "Files changed" tab. I am checking some of the older commits, none of them seem to add any location of changes in the title. I cannot understand what changed recently, I did not commit to this repo for the first time. Can you please direct me to one such "ideal" PR to take as an example? I am curious at this point. Thank you.

[vkucera]

Sorry, I am confused here. The locations of the changes made to the file cannot be put in the title itself, there are too many changes, and therefore, we have the "Files changed" tab. I am checking some of the older commits, none of them seem to add any location of changes in the title. I cannot understand what changed recently, I did not commit to this repo for the first time. Can you please direct me to one such "ideal" PR to take as an example? I am curious at this point. Thank you.

@nmallick19 There are examples in the contribution guidelines. Did you actually read them?
@jaelpark Why did you merge the PR with the incomplete title?

[jaelpark]

I don't see either what makes it incomplete. The location was added, and the title describes the changes. I assume you refer to the guidelines here. Everything checks out.

[vkucera]

I don't see either what makes it incomplete. The location was added, and the title describes the changes. I assume you refer to the guidelines here. Everything checks out.

Yes, specifically to

To specify where, you can use a prefix with the name of the file or of the analysis or of the framework component.

Which one of these is in the title?

[nmallick19]

The framework component is the "magnetic field CCDB path". There is only one function which uses this path, rest are all call sites. This was hard coded to Run 2 path in the older version, which failed to run on Run 3 AO2D or filtered data. So, this path is now added with a configurable switch, so that one can use whichever path needed. Also, the field is now cached per run number, so repetitive calls to the CCDB is avoided which was being done per timestamp in the older version. More smarter version, if any, is welcome!

[jaelpark]

I'm not sure we have referred to the top-level CF correlations tasks with any particular name or further specifics in the past, but if that is desired, we will come up with something for the future.

[vkucera]

The framework component is the "magnetic field CCDB path".

No it's not. The PR modifies local properties of a single task.

[vkucera]

I'm not sure we have referred to the top-level CF correlations tasks with any particular name or further specifics in the past, but if that is desired, we will come up with something for the future.

As written in the guidelines, the file name would be perfectly fine. Without it, it's impossible to tell from the title where in the CF these changes were made.