Skip to content

[PWGHF] Add EMCal-registered event selection for hadrons in event mixing - #17741

Open
rashigupt wants to merge 31 commits into
AliceO2Group:masterfrom
rashigupt:rashi
Open

[PWGHF] Add EMCal-registered event selection for hadrons in event mixing#17741
rashigupt wants to merge 31 commits into
AliceO2Group:masterfrom
rashigupt:rashi

Conversation

@rashigupt

Copy link
Copy Markdown
Contributor

This update adds the EMCal-registered event selection when filling the hadron table used for event mixing in CorrelatorHfehadron.cxx. This ensures that only hadrons from EMCal-registered events are included in the mixed-event correlation analysis.

rashi234 and others added 29 commits March 23, 2026 19:34
…ection table

Introduce MC changes for efficiency estimation and extend electron selection table with additional variables
Used getcharmHadron Function
Add EMCal-registered event selection for hadrons in event mixing
@rashigupt
rashigupt requested a review from alibuild as a code owner September 3, 2026 04:32
@github-actions github-actions Bot added the pwghf PWG-HF label Sep 3, 2026
@github-actions github-actions Bot changed the title Add EMCal-registered event selection for hadrons in event mixing [PWGHF] Add EMCal-registered event selection for hadrons in event mixing Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 655e3b0 at 2026-09-03 11:30:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 655e3b0 at 2026-09-04 01:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/31fb27c457cb089657ce2691db25a824f439791d/O2Physics-code-check/errors.txt
PWGHF/HFC/TableProducer/correlatorHfeHadrons.cxx:288:9: error: variable 'cntEle' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorHfeHadrons.cxx:302:45: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@rashigupt

Copy link
Copy Markdown
Contributor Author

Dear Expert, the code builds successfully on my local machine.

@vkucera

vkucera commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Dear Expert, the code builds successfully on my local machine.

You still have a compilation warning.

Remove Cntele warning
@alibuild

alibuild commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a97a334 at 2026-09-08 03:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/45aa122dc4712ae78ea55c45156a4963db00f77b/O2Physics-code-check/errors.txt
PWGHF/HFC/TableProducer/correlatorHfeHadrons.cxx:301:45: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@rashigupt

Copy link
Copy Markdown
Contributor Author

Dear expert , please approve and merge the code.

@rashigupt

Copy link
Copy Markdown
Contributor Author

Dear experts,
If there are no further comments or suggestions, could you please approve and merge the code?
Thank you for your time.

Comment on lines 301 to 305

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bodies are identical. Please combine the conditions into one, as suggested by the code check.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnakyou @vkucera, I have resolved the issue as suggested by the code check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

4 participants