Skip to content

[PWGLF] Update forwardlambdakzeroanalysis - #17664

Merged
romainschotter merged 2 commits into
masterfrom
romainschotter-patch-1
Aug 30, 2026
Merged

[PWGLF] Update forwardlambdakzeroanalysis#17664
romainschotter merged 2 commits into
masterfrom
romainschotter-patch-1

Conversation

@romainschotter

Copy link
Copy Markdown
Collaborator
  • add new QA histograms
  • fix the V0 Z cut
  • address some of the cpp code-check errors

@github-actions github-actions Bot added the pwglf label Aug 30, 2026
@github-actions github-actions Bot changed the title Update forwardlambdakzeroanalysis [PWGLF] Update forwardlambdakzeroanalysis Aug 30, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 12 errors, ⚠️ 17 warnings, 🔕 0 disabled

@romainschotter
romainschotter marked this pull request as ready for review August 30, 2026 20:21
@romainschotter
romainschotter enabled auto-merge (squash) August 30, 2026 20:23

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ed55bc2 at 2026-08-30 22:39:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 71 warnings.'
Found 3 errors and 71 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/26be1d42c3452bbf42a07ae65b0d9e266d32da8e/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:91:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:92:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:188:67: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
++ [[ 71 -gt 0 ]]
++ cat /sw/BUILD/26be1d42c3452bbf42a07ae65b0d9e266d32da8e/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:159:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:380:5: warning: function 'positivePt' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:381:5: warning: function 'negativePt' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:382:5: warning: function 'positivePz' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:383:5: warning: function 'negativePz' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:384:5: warning: function 'positivePtMc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:385:5: warning: function 'negativePtMc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:386:5: warning: function 'positivePzMc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:387:5: warning: function 'negativePzMc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:722:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:724:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:726:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:728:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:730:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1353:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1358:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1363:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1368:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1373:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1487:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1489:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1491:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1493:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1554:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1556:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1558:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1560:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1620:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1622:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1624:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1626:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1686:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1688:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1690:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1692:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1752:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1754:31: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit f8ed2f5 into master Aug 30, 2026
12 of 16 checks passed
@romainschotter
romainschotter deleted the romainschotter-patch-1 branch August 30, 2026 20:46
@vkucera

vkucera commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

@romainschotter Please use a more informative PR title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants