Skip to content

[PWGLF] Autoset the tables produced based on the task topology#16922

Closed
njacazio wants to merge 4 commits into
masterfrom
nj-mccent-autoset
Closed

[PWGLF] Autoset the tables produced based on the task topology#16922
njacazio wants to merge 4 commits into
masterfrom
nj-mccent-autoset

Conversation

@njacazio

@njacazio njacazio commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@njacazio
njacazio marked this pull request as ready for review July 3, 2026 20:09
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot added the pwglf label Jul 3, 2026
@github-actions github-actions Bot changed the title Autoset the tables produced based on the task topology [PWGLF] Autoset the tables produced based on the task topology Jul 3, 2026
@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 81f5ace at 2026-07-03 22:10:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/mcCentrality.cxx:96:5: error: 'enableFlagIfTableRequired' was not declared in this scope; did you mean 'o2::common::core::enableFlagIfTableRequired'?
ninja: build stopped: subcommand failed.

Full log here.

@njacazio
njacazio enabled auto-merge (squash) July 3, 2026 20:12
@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for b7268f4 at 2026-07-03 22:13:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/mcCentrality.cxx:97:5: error: 'enableFlagIfTableRequired' was not declared in this scope; did you mean 'o2::common::core::enableFlagIfTableRequired'?
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b7268f4 at 2026-07-03 22:22:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/mcCentrality.cxx:97:5: error: 'enableFlagIfTableRequired' was not declared in this scope; did you mean 'o2::common::core::enableFlagIfTableRequired'?
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for b7268f4 at 2026-07-04 07:41:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/mcCentrality.cxx:97:5: error: 'enableFlagIfTableRequired' was not declared in this scope; did you mean 'o2::common::core::enableFlagIfTableRequired'?
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft July 4, 2026 13:08
auto-merge was automatically disabled July 4, 2026 13:08

Pull request was converted to draft

@njacazio
njacazio marked this pull request as ready for review July 5, 2026 09:45
@njacazio
njacazio enabled auto-merge (squash) July 5, 2026 09:46
@alibuild

alibuild commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3626810 at 2026-07-18 16:59:

## sw/BUILD/O2Physics-latest/log
2026-07-18T16:55:07.736+0200 [23:140378692262464] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T16:55:07.737+0200 [23:140378692262464] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-18T16:55:46.489+0200 [23:140378692262464] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/cebfb7b48518a482925cc2c1774a134337e9d5b4/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Common/mcCentrality.cxx:51:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Common/mcCentrality.cxx:114:20: error: use starts_with instead of rfind [modernize-use-starts-ends-with,-warnings-as-errors]
PWGLF/TableProducer/Common/mcCentrality.cxx:133:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/TableProducer/Common/mcCentrality.cxx:143:19: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Utils/inelGt.h:117:11: error: using integer absolute value function 'abs' when argument is of floating point type [clang-diagnostic-absolute-value,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera
vkucera disabled auto-merge July 8, 2026 12:00

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njacazio Please fix the bugs.

@vkucera
vkucera marked this pull request as draft July 19, 2026 11:10
@njacazio

Copy link
Copy Markdown
Collaborator Author

I did not realise this was still open, thanks!

@njacazio njacazio closed this Jul 19, 2026
@njacazio
njacazio deleted the nj-mccent-autoset branch July 19, 2026 11:48
@vkucera

vkucera commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

I did not realise this was still open, thanks!

What about the bugs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants