[PWGCF] Flow event plane update for online-offline recentering#16797
Merged
Conversation
yashpatley
requested review from
alibuild,
jaelpark,
lauraser,
shouqiye,
victor-gonzalez and
wenyaCern
as code owners
June 24, 2026 13:11
|
O2 linter results: ❌ 0 errors, |
wenyaCern
approved these changes
Jun 24, 2026
wenyaCern
enabled auto-merge (squash)
June 24, 2026 13:28
vkucera
reviewed
Jun 29, 2026
Comment on lines
+373
to
+379
| struct CorrectionHistContainer { | ||
| TProfile* hVx; | ||
| TProfile* hVy; | ||
| std::array<TH2F*, 2> hGainCalib; | ||
| std::array<std::array<std::array<THnSparseF*, 1>, 4>, 14> vCoarseCorrHist; | ||
| std::array<std::array<std::array<TProfile*, 4>, 4>, 14> vFineCorrHist; | ||
| } CorrectionHistContainer; |
Collaborator
There was a problem hiding this comment.
- Always initialise pointers.
- Don't use the same name for the object and its type.
mcoquet642
pushed a commit
to AliceMCH/O2Physics
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.