Skip to content

[O2B-1599] Use datetime local input rather than split inputs (date and time) for date time filters and inputs#2193

Merged
graduta merged 6 commits into
mainfrom
feature/O2B-1599/use-datetime-local-input-rather-than-split-inputs
Jul 17, 2026
Merged

[O2B-1599] Use datetime local input rather than split inputs (date and time) for date time filters and inputs#2193
graduta merged 6 commits into
mainfrom
feature/O2B-1599/use-datetime-local-input-rather-than-split-inputs

Conversation

@graduta

@graduta graduta commented Jul 17, 2026

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Users will now have only one input that accepts both dates and times for filtering, creating qc flags, etc.
  • [O2B-1598] fixes a bug where the inputs for date and time would not be reset by clicking "X" button icon

Notable changes for developers:

  • given the fact that it is not using html native input time, it means some logic behind (such as calculating times for days on change of different inputs) is now no longer needed and instead it can easily compare to one value only

@graduta graduta self-assigned this Jul 17, 2026
@graduta
graduta requested a review from isaachilly as a code owner July 17, 2026 09:40
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.11%. Comparing base (9bc3ef9) to head (03adc20).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nents/common/form/inputs/DateTimeInputComponent.js 0.00% 10 Missing ⚠️
...omponents/common/form/inputs/DateTimeInputModel.js 0.00% 4 Missing ⚠️
...ents/common/form/inputs/TimestampInputComponent.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2193      +/-   ##
==========================================
+ Coverage   46.00%   46.11%   +0.11%     
==========================================
  Files        1039     1039              
  Lines       17189    17146      -43     
  Branches     3146     3124      -22     
==========================================
  Hits         7907     7907              
+ Misses       9282     9239      -43     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta
graduta merged commit 613d9c5 into main Jul 17, 2026
22 of 24 checks passed
@graduta
graduta deleted the feature/O2B-1599/use-datetime-local-input-rather-than-split-inputs branch July 17, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant