Repository navigation
Avoid multi-loopers generation when using embedding - #16015
Open
jackal1-66 wants to merge 1 commit into
Open
jackal1-66 wants to merge 1 commit into
jackal1-66 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With embedding, the background and the signal simulation each cover the whole timeframe with TPC loopers, so the loopers reach the digits basically twice. A collision of the collision context is now owned by a single source, and only its owner generates its loopers. A protection has been added in the Generator class not to make generators that do not own collisions (rare case) enable the loopers flag. The applied fix has been validated against multiple embedding configurations (both with and without replacement) and with the standard simulations as well. The issue is tracked by https://its.cern.ch/jira/browse/O2-7272 and was discovered in https://its.cern.ch/jira/browse/O2-6781. A simple veto to the signal was also investigated, but the generated loopers were incorrect in the time intervals both in replace mode and when the background events were reused.