Skip to content

feat: block only on vulnerabilities in runtime dependencies - #2

Merged
robertodr merged 1 commit into
mainfrom
feat/runtime-only
Nov 19, 2026
Merged

robertodr merged 1 commit into
mainfrom
feat/runtime-only

Conversation

@robertodr

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Findings now block a merge only when they are in a runtime dependency. Findings in packages that only the dependency groups need (dev, test, docs, …) are still listed in the job summary, marked "development", but don't fail the check.

Changes

  • scripts/dependency_scan.py: runtime_packages walks the lock from its projects (editable or virtual packages) and their extras, through the dependencies and the extras each one asks for, but not the dependency groups. With several versions of a package locked, it follows the version each dependency names. A lock without a project counts every package as a runtime dependency, so nothing is skipped by mistake.
  • The job summary has a column "Needed at" (run time or development).
  • README.md: what counts as a runtime dependency, and that tools listed in [project] dependencies count: move them to a dependency group.
  • Tests: the walk on a lock with a dependency group, an extra of the project, an extra a dependency asks for, an extra nobody asks for and two versions of one package. Also: a lock without a project, a critical finding in a development package, and end to end, a vulnerable package in a dev group that passes.

Validation

  • 30 tests pass; ruff, actionlint and zizmor report nothing.
  • On the current locks of the repositories the ruleset targets, the blocking findings go from 71 to 51 (aurora-database), 50 to 33 (aurora-optimization), 109 to 75 (mariorana) and 122 to 91 (aurora-qiskit-function). Those left are runtime packages: mostly pillow, aiohttp, pyjwt, urllib3, cryptography and certifi. aurora-experiments stays at 106, because it lists development tools (jupyter, black, pytest, …) in its [project] dependencies.

A finding now blocks only when the package is a runtime dependency: one
that a project of the lock needs, through its dependencies and extras
and the extras they ask for. Packages that only dependency groups need
(dev, test, docs, ...) don't ship with the project: their findings are
reported in the job summary, marked "development", without failing.
A lock without a project counts every package as a runtime dependency.

Assisted-by: Pi:claude-opus-5-5
@robertodr
robertodr merged commit f72357f into main Nov 19, 2026
3 checks passed
@robertodr
robertodr deleted the feat/runtime-only branch November 19, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant