Repository navigation
fix(test): skip symlink save test when symlinks are unavailable - #21
Merged
Merged
Conversation
Creating symlinks on Windows requires Developer Mode or admin rights. Without them, test_save_replaces_symlink_instead_of_following_it errored with WinError 1314 during setup. Skip the test when os.symlink raises OSError, the same way the permissions test skips on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Creating symlinks on Windows requires Developer Mode or admin rights. Without
them, test_save_replaces_symlink_instead_of_following_it errored with WinError
1314 during setup, which looks like a broken build. The test now skips when
os.symlink raises OSError, the same way the permissions test skips on Windows.
Single commit.
Behavior changes
None
Testing
python -m unittest discover tests: 1158 tests pass (K skipped) on Windows.when symlinks are unavailable.