fix: resolve race condition preventing concurrent permission gates fr…

[utkarshtyagi-253]

Fixes #5545

Summary

• Include deferred approval requests in pending approval count
• Enable batch approve/deny UI when multiple approvals are waiting
• Preserve existing single-approval behavior

Testing

• Reproduced with 3 simultaneous approval requests
• Verified batch Approve all / Deny all button appears

[github-actions]

Hi @utkarshtyagi-253, thanks for opening a pull request. 🙏

This PR was automatically closed because it does not yet meet our contribution requirements:

• This PR changes functional code (SDK, API, or frontend) but includes no demo. Add a screenshot or short video of the change. Only test-only, docs-only, or chore changes may skip it.

We ask for this so every change is documented and demonstrably tested before review.

How to get it reopened
Update the PR description (and add a demo recording if your change touches functional code). The bot reopens the PR automatically once the requirements are met. No need to open a new one.

See the Contributing guide and Creating your first PR. If you think this was closed in error, leave a comment and a maintainer will take a look.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 616813d4-9b0b-4f91-9c21-a5610e3e1374

📥 Commits

Reviewing files that changed from the base of the PR and between a3e7fdf and 9a295a0.

📒 Files selected for processing (3)

• services/runner/src/engines/sandbox_agent/acp-interactions.ts
• services/runner/src/engines/sandbox_agent/pause.ts
• services/runner/src/engines/sandbox_agent/run-turn.ts

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of tool-call permission requests during pauses.
  • Prevented active permission requests from being prematurely marked as incomplete or closed.
  • Improved tracking of permission requests as they move through pending, approved, denied, and paused states.

Walkthrough

The runner now reports when ACP permission requests begin, tracks their tool-call IDs in pause state, and prevents paused turns from prematurely settling those calls before permission resolution.

Changes

Sandbox permission lifecycle

Layer / File(s)	Summary
ACP permission-start callbacks services/runner/src/engines/sandbox_agent/acp-interactions.ts	Adds the optional callback to permission responder inputs and invokes it for Pi and standard ACP gates before permission handling.
In-flight pause-state integration services/runner/src/engines/sandbox_agent/pause.ts, services/runner/src/engines/sandbox_agent/run-turn.ts	Tracks in-flight permission tool calls, clears them when paused or allowed, and excludes them from premature settlement during paused turns.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

• Agenta-AI/agenta#5550: Adds the same permission-start callback and in-flight tracking across the sandbox permission lifecycle.
• Agenta-AI/agenta#5382: Generalizes approval handling for multiple parallel ACP permission gates.
• Agenta-AI/agenta#5267: Adjusts pause and terminalization handling for paused tool calls.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Fix failing CI checks

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}