Skip to content

[fix] Remove the redundant boolean annotation that fails TypeScript lint - #5462

Merged
mmabrouk merged 1 commit into
release/v0.105.9from
fix/release-0-105-9-lint
Jul 23, 2026
Merged

[fix] Remove the redundant boolean annotation that fails TypeScript lint#5462
mmabrouk merged 1 commit into
release/v0.105.9from
fix/release-0-105-9-lint

Conversation

@mmabrouk

Copy link
Copy Markdown
Member

Context

The TypeScript lint job is red on release/v0.105.9. It has been red since the commit that hid the context-window meter from the agent composer (535f6a2), so it is not caused by PR #5461. That commit wrote the feature flag as const showContextBudget: boolean = false, and ESLint's @typescript-eslint/no-inferrable-types rejects an annotation the initialiser already implies.

Changes

The annotation is gone. The line is now const showContextBudget = false, which keeps the flag exactly as it was for anyone flipping it back on.

Tests / notes

  • pnpm lint in web/ passes, all 11 tasks.
  • tsc --noEmit on web/oss reports nothing for this file. The narrower false type does not upset the one place the flag is read.
  • The remaining lint output on that job is warnings only, from the TanStack Virtual React Compiler notices in DriveExplorer.tsx and VirtualTileGrid.tsx. Those do not fail the job and are untouched here.

…dget

`no-inferrable-types` fails the TypeScript lint job on release/v0.105.9.

Claude-Session: https://claude.ai/code/session_01LMcS17kn4KEdoWucKttuzD
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 23, 2026
@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jul 23, 2026 12:21pm

Request Review

@dosubot dosubot Bot added the typescript label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a3382217-23ca-463b-aec9-af9397d0510a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-0-105-9-lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmabrouk
mmabrouk merged commit c637057 into release/v0.105.9 Jul 23, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant