test(web): migrate session-mounts-store test to the object-param mountFilesQueryFamily - #5437
Closed
mmabrouk wants to merge 1 commit into
Closed
test(web): migrate session-mounts-store test to the object-param mountFilesQueryFamily#5437mmabrouk wants to merge 1 commit into
mmabrouk wants to merge 1 commit into
Conversation
…tFilesQueryFamily
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughUpdated session mount store tests to pass mount identifiers through the object-form ChangesMount query test updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
closing as duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
Two unit tests fail on main's own tip (verified in a clean clone of
origin/main), which turns the required run-web-unit-tests check red for every open PR:Both assert on
mountFilesQueryFamily(...)data, which staysundefinedforever.Cause
The drive-surfaces data layer (#5400, commit e280384, landed via the v0.105.7 release merge) changed
mountFilesQueryFamily's parameter from a plainmountId: stringto{mountId, includeGitignored?}so the git-ignored toggle can key its own cache entry. All product callers were migrated (useSessionDrive.ts,useLazyDriveTree.tsx), but this unit test still passes the bare string. Destructuring{mountId}from a string yieldsundefined, so the query'senabledguard stays false, the fetch never runs, anddataisundefined.The store's behavior is correct; only the test was left on the old contract.
Fix
Update the test's six
mountFilesQueryFamily(MOUNT.id)call sites tomountFilesQueryFamily({mountId: MOUNT.id}). No product code changes.Tests
Full
agenta-entitiesunit suite:pnpm exec tsc --noEmitin the package: clean.