Skip to content

feat(frontend): elicitation Next/Accept, shortcut hints, reviewable answers - #5262

Merged
ardaerzin merged 4 commits into
big-agentsfrom
fe-fixes/agent-elicitation
Jul 12, 2026
Merged

feat(frontend): elicitation Next/Accept, shortcut hints, reviewable answers#5262
ardaerzin merged 4 commits into
big-agentsfrom
fe-fixes/agent-elicitation

Conversation

@ardaerzin

Copy link
Copy Markdown
Contributor

Context

The paginated elicitation form (the stepper the agent shows to collect input) had three problems. Its only action was "Accept", enabled as soon as the required fields anywhere in the form were filled, so you could submit at step 2 of 5 before seeing later questions. The keyboard shortcuts were undiscoverable. And after submitting, the answers were hidden behind a one-line chip.

Changes

The primary action is now "Next" while you step through questions and becomes "Accept" only on the final review step, enabled once the required fields are filled. Choice-pick no longer auto-advances, so a selection never skips ahead before you see the next question.

A hint row under the form shows the shortcuts that apply to the current question: back and next arrows only when those steps exist, and 1-9 pick only on choice-card questions. Enter stays reserved for sending in the composer.

Submitted answers are now a collapsible summary that reuses the chat's tool-step collapse, so you can expand a settled form and see every value you gave. The answers survive a reload.

Tests / notes

  • Package typecheck and unit suites pass (195 entity-ui tests).
  • SchemaForm is shared with the trigger forms; the new props are optional and inert for non-stepper forms.

What to QA

  • Trigger a multi-question stepper form. The primary button reads "Next" until the review step, then "Accept", disabled until required fields are filled. You cannot submit before review.
  • Pick a choice-card answer. It selects without jumping to the next question.
  • The hint row shows only relevant hints: no "1-9 pick" on a text-only question, no "back" on the first step.
  • Submit the form, then expand the settled row. Your answers show. Reload and expand again; they still show.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 471838e0-01ef-4e97-aa74-345a188689f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds stepper-aware SchemaForm state and navigation, exposes reusable form and shortcut APIs, and updates ElicitationWidget with collapsible submitted answers plus step-specific controls.

Changes

Elicitation stepper flow

Layer / File(s) Summary
Stepper and reusable UI contracts
web/packages/agenta-entity-ui/src/gatewayTool/components/SchemaForm.tsx, web/packages/agenta-entity-ui/src/gatewayTool/index.ts, web/packages/agenta-ui/src/RichChatInput/*
SchemaForm exposes step metadata, navigation methods, and review formatting; ShortcutHint and related exports are made public.
SchemaForm stepper navigation
web/packages/agenta-entity-ui/src/gatewayTool/components/SchemaForm.tsx
SchemaForm reports step and review state, supports next/previous navigation, and no longer auto-advances after selections in stepper mode.
Elicitation rendering and controls
web/oss/src/components/AgentChatSlice/components/clientTools/ElicitationWidget.tsx
ElicitationWidget renders collapsible submitted answers and changes shortcuts and the primary action based on stepper state.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant ElicitationWidget
  participant SchemaForm
  User->>ElicitationWidget: Open elicitation
  ElicitationWidget->>SchemaForm: Render form
  SchemaForm-->>ElicitationWidget: Report step state
  User->>ElicitationWidget: Choose Next or previous
  ElicitationWidget->>SchemaForm: Navigate step
  SchemaForm-->>ElicitationWidget: Update step state
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main frontend elicitation changes: Next/Accept flow, shortcut hints, and reviewable submitted answers.
Description check ✅ Passed The description matches the implemented stepper behavior, shortcut hints, and collapsible submitted-answer summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fe-fixes/agent-elicitation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature Request New feature or request Frontend UX labels Jul 12, 2026
@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jul 12, 2026 10:18pm

Request Review

@ardaerzin

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ardaerzin
ardaerzin merged commit ed20dee into big-agents Jul 12, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Request New feature or request Frontend size:L This PR changes 100-499 lines, ignoring generated files. UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant