fix(frontend): anchor Inspect turn before the working dots - #5161
Conversation
The dots rendered first in the meta row, so when the run settled and they unmounted, Inspect turn jumped left (and sat indented relative to older turns while busy). Render the affordance first and let the dots trail it: the button's left edge never moves.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change adjusts rendering order within AgentChatPanel's meta row so that the WorkingDots indicator now appears after the "Inspect turn" button instead of before it, along with an updated inline comment explaining the layout. ChangesMeta-row Rendering Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Context
Follow-up to #5159. The working dots rendered first in the meta row under the last turn, with "Inspect turn" after them. Two visual defects: when the run settled the dots unmounted and the button jumped left by the dots' width, and while a run was busy the last turn's button sat indented relative to the buttons on older turns above it.
Changes
Pure JSX reorder in
AgentChatPanel: the "Inspect turn" affordance now renders first and the dots trail it (Inspect turn · · ·). The button's left edge is anchored and aligned across all turns at all times; the dots appear and vanish at the trailing end of the line, where nothing follows them, so settling moves nothing. In chat mode (no inspect button) the dots stand alone as before.Keeping the dots on the left with permanently reserved width was considered and rejected: it would indent every turn's button forever for a transient signal.
Tests / notes
eslintandprettierclean. The diff swaps two existing JSX blocks inside the same row; no logic or types changed.What to QA