Repository navigation
Supercars modelled in Blender: a Lambo wedge and a curvy Ferrari, with real wheels and a cockpit - #281
Open
muguetdev wants to merge 2 commits into
Open
Supercars modelled in Blender: a Lambo wedge and a curvy Ferrari, with real wheels and a cockpit#281muguetdev wants to merge 2 commits into
muguetdev wants to merge 2 commits into
Conversation
… wheel arches, five-spoke rims and calipers, a glass cabin and a roof-off cockpit, from build_cars.py
|
@muguetdev Images are broken |
Contributor
|
could you fix images so I can checkout the models before merging? |
…the hood, no arch lining poking out), a cockpit sunk into the body with a dashboard, and a see-through windshield with the roof off
Contributor
Author
|
Sorry about that: the screenshots never made it up. They're fixed now, and the description shows the current models. I've also pushed an update (d1eb581) since the first version:
There are two new shots of driving with the roof off, in third person and from the driver's seat. Typecheck, the tests and the build pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The garage's cars were extruded side profiles with boxes on top, so they read as bricks: no wheel arches, flat disc wheels, and no curve anywhere. This replaces them with models made in Blender by a script, the way the dog, the plants, the kitchen and the lounge already are.
Driving, with the roof off:
The cars
How it plugs in
blender/scripts/build_cars.pywritessrc/client/models/cars.glb. Each car is five roots:<kind>,<kind>_top,<kind>_open,<kind>_wheel_land<kind>_wheel_r. The front wheels have their origins at their hubs, so steering turns them as before.supercar()infeatures/cars/world.tsbuilds a car from those pieces withpiece(), paintingPaintin each car's own colour. Lamp and Tail are the same glowing materials as before, Glass is double-sided, and Screen (the windshield left with the roof off) is see-through.root,top,open,wheels). Driving, colliders, seats, the camera and sound are untouched, and so are the colours and spots inshared/garage.ts.cars.glbdoesn't load, it falls back to the old code-built car, so the garage never comes up empty.cars.glbis 575 KB and preloaded with the other world models, about a dog's size. A car is about 15k triangles, wheels and cockpit included.tests/cars-model.test.tschecks what the code counts on:CAR's length and width) and the roof height;SEATSwith a steering wheel in front of the driver;tests/support/css-loader.mjs) now gives a.glbimport an empty URL, as it gives a stylesheet an empty module, sincefeatures/cars/world.tsnow importsworld/models.ts.tests/driving.test.tsimports it and runs with the code-built fallback.blender/README.mdlists the new script.Typecheck, the 612 tests and the build pass. Checked in a headless browser: