Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Codex lifecycle hook commands currently use POSIX shell quoting on Windows. Launch the helper through an encoded PowerShell command on win32 so it works from both PowerShell and Command Prompt, including paths with spaces, apostrophes and shell metacharacters. Other platforms keep their existing quoting.
Adds a Windows execution test covering stdin forwarding and authenticated lifecycle events through both shells. Also increases the project floor limit from 16 to 32 and documents both behaviors.
Based on upstream main at 7f7211e. The already merged npm run dev startup fix (#224) is included in the base; this PR addresses a separate Codex hook issue. The public lobby feature is a separate PR.
Validation
Draft pending the contributor's interactive testing and CI/review. No preceding issue was opened.