Skip to content

Negative/out-of-order clocks silently pass check_latency #15

Closed
#17
Closed
Negative/out-of-order clocks silently pass check_latency#15
#17
Labels
good first issueGood for newcomershelp wantedExtra attention is needed

Description

@royalpinto007
royalpinto007
opened on Sep 6, 2026

Problem

Corrupt fixtures pass silently: an agent turn starting before the user turn ends (negative gap) yields zero findings instead of flagging bad timing data.

Where

voiceeval/checks.py (check_latency: gap = agent.start_s - user.end_s, only gap > budget flagged).

Acceptance

Add a failing test first with overlapping/out-of-order timestamps, asserting a finding (or explicit invalid-timing error) rather than silence. Then fix.

Activity

  1. royalpinto007
    added
    help wantedExtra attention is needed
    good first issueGood for newcomers
    on Sep 6, 2026

  2. mikemikimike commented on Sep 6, 2026

    @mikemikimike
    mikemikimike
    on Sep 6, 2026
    Contributor

    Implemented and opened PR #17 for this issue.

    • check_latency now reports a high-severity invalid_timing finding when an agent starts before the caller's turn ends, including the overlap duration and agent turn index.
    • Existing non-negative latency thresholds and slow_response behavior are unchanged.
    • Added a regression test covering the finding, severity, location, and message; the test failed against the base commit and passes with the fix.
    • Updated the README test count.

    Local verification passed:

    • 20/20 pytest tests
    • Ruff lint and formatting for the modified files
    • Clean fixture CLI smoke test exits 0 with --strict
    • Misheard fixture CLI smoke test exits 1 with --strict
    • Wheel build succeeds

    GitHub CI passed for exact head 84472e0ef3e91596d834df2524ef954453ca3085:

    • ci run
    • Python 3.11 test: passed
    • Python 3.12 test: passed
  3. royalpinto007
    closed this as completedin #17on Sep 6, 2026
  4. royalpinto007
    added a commit that references this issue on Sep 6, 2026

    fix: reject out-of-order voice timing (#17)

    b522615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions