Skip to content

docs(otelcollector): name the parameter that exists, and drop a branch that does not #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxcxjxhx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(otelcollector): name the parameter that exists, and drop a branch that does not #1484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions app/opentelemetry-collector/builder/otelcollector_config/template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ def _render_template(template_name: str, context: Dict[str, Any], output_dir: st
Args:
template_name: Name of the template to render
context: Dictionary of variables to pass to the template
output_path: Optional path to write the rendered template
If None, the rendered template is only returned
output_dir: Directory to write the rendered template into
"""
template = renderer.get_template(template_name)
output_path = f"{output_dir}/{template_name.replace('.tpl', '')}"
Expand All @@ -76,8 +75,7 @@ def render_base_config(output_dir: Optional[str] = None) -> None:
Render the base configuration template.

Args:
output_path: Optional path to write the rendered template.
If None, the rendered template is only returned.
output_dir: Directory to write base.yaml into.
"""
# wee don't transform this file, so just copy it to the output path
shutil.copy(
Expand All @@ -91,8 +89,7 @@ def render_processors_config(output_dir: Optional[str] = None) -> None:
Render the processors.yaml.tpl template with model costs.

Args:
output_path: Optional path to write the rendered template.
If None, the rendered template is only returned.
output_dir: Directory to write the rendered template into.
"""
model_costs: list[ModelCost] = load_model_costs()
context = {
Expand Down