Report a failed first connect once - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the first connection attempt failed with auto-reconnect off, the connection loop and
ConnectAsyncboth finalized the disconnect. Whichever ran first decided the reasonDisconnectedreported: either the loop's "failed to connect after 1 attempts" or the bare attempt failure. That madeConnectAsync_ConnectionFailedFirstAttempt_NoRetry_RaisesCorrectEventsflaky on the Linux runner, and it failed on master after #47.ConnectAsyncnow waits for the loop when the loop is the one that gave up, soDisconnectedfires once, with the loop's reason, beforeConnectAsyncthrows. Timeouts and caller cancellation, where the loop may still be retrying, still stop it directly.The new test holds the loop at the point it gives up, which makes the race deterministic. It failed on every run before this change.