Repository navigation
fix(backup): detect content replacement during offline verification - #249
Draft
Adam-Ghanem wants to merge 4 commits into
Draft
Adam-Ghanem wants to merge 4 commits into
Adam-Ghanem wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Stacked on #199; do not merge before its verifier baseline is reviewed. Rehash the SQLite snapshot after read-only integrity/schema/count checks, rejecting content changes even when file size and mtime remain unchanged. Add a deterministic regression test and document the immutable-offline-snapshot requirement.
Evidence
Commits: 6d61096 (guard), 3df524c (regression), 7411449 (docs).
74114498a9a46f7978bc11252ad080db676f4f87returned this Security CI run. Python CI was not returned and remains unverified; no local pytest run. A commit-associated PR run may check out a generated merge ref rather than raw branch HEAD.Review gates / limitations
Two hashes narrow but cannot eliminate races on mutable files; operators must verify an offline immutable snapshot. No audit HMAC, authenticated staging restore, or RTO/RPO proof is claimed. Keep draft pending Python CI verification and review of #199 stack.