Skip to content

fix(recovery): reject unknown RFC3339 timezone offsets in drill evidence - #240

Draft
Adam-Ghanem wants to merge 4 commits into
test/restore-rto-rpo-evidence-20261115from
fix/restore-unknown-offset-20261115
Draft

Adam-Ghanem wants to merge 4 commits into
test/restore-rto-rpo-evidence-20261115from
fix/restore-unknown-offset-20261115

Conversation

@Adam-Ghanem

@Adam-Ghanem Adam-Ghanem commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Why

RFC 3339 -00:00 represents an unknown local timezone offset. Python datetime.fromisoformat interprets it as UTC, silently treating uncertain operator evidence as a known instant and potentially making RTO/RPO measurements misleading.

Change

  • Reject timestamps ending in -00:00 with controlled ValueError (CLI exit 2, no JSON).
  • Add regression test for unknown-offset evidence.
  • Document the accepted timezone policy.

Scope

Offline, read-only helper only. No network access, credentials, API spend, active remediation, or production restore. Stacked on PR #239 to avoid duplicating its unmerged helper.

Verification — 2026-11-15

  • Previous head 43934e8: Security CI #43749809857 completed/success; checked job steps including dependency audit, secret boundary, container build and test suite. Python CI was not returned by commit-associated workflow lookup.
  • Current head d884112 adds CLI regression coverage asserting invalid unknown-offset evidence exits 2 with no JSON stdout. CI on this new head is not yet confirmed; previous green Security CI is not proof for the new commit.
  • No local full pytest, isolated staging restore, or production recovery executed. Keep draft pending CI and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant