Repository navigation
fix(recovery): reject unknown RFC3339 timezone offsets in drill evidence - #240
Draft
Adam-Ghanem wants to merge 4 commits into
Draft
Adam-Ghanem wants to merge 4 commits into
Adam-Ghanem wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RFC 3339
-00:00represents an unknown local timezone offset. Pythondatetime.fromisoformatinterprets it as UTC, silently treating uncertain operator evidence as a known instant and potentially making RTO/RPO measurements misleading.Change
-00:00with controlledValueError(CLI exit 2, no JSON).Scope
Offline, read-only helper only. No network access, credentials, API spend, active remediation, or production restore. Stacked on PR #239 to avoid duplicating its unmerged helper.
Verification — 2026-11-15
43934e8: Security CI #43749809857 completed/success; checked job steps including dependency audit, secret boundary, container build and test suite. Python CI was not returned by commit-associated workflow lookup.d884112adds CLI regression coverage asserting invalid unknown-offset evidence exits 2 with no JSON stdout. CI on this new head is not yet confirmed; previous green Security CI is not proof for the new commit.