Skip to content

simd: trampoline hpc::cascade as ndarray::simd::cascade - #273

Merged
AdaWorldAPI merged 1 commit into
masterfrom
claude/x265-x266-plans-review-h9osnl
Aug 5, 2026
Merged

simd: trampoline hpc::cascade as ndarray::simd::cascade#273
AdaWorldAPI merged 1 commit into
masterfrom
claude/x265-x266-plans-review-h9osnl

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Aug 5, 2026

Copy link
Copy Markdown
Owner

What

One re-export: pub use crate::hpc::cascade; inside src/simd.rs, making the Belichtungsmesser surface (Cascade::expose → Band, recalibrate(ShiftAlert), PackedDatabase, adaptive_resolution, RankedHit, PreciseMode) reachable as ndarray::simd::cascade::*.

Why

The consumer stack enforces "all SIMD from ndarray::simd" (the simd-savant invariant). The banded exposure-meter machinery lives under crate::hpc::cascade, so consumers computing distribution-shape / percentile-rank payloads (the Prozentrang work in the downstream stack) had no sanctioned path to it. This follows the established trampoline pattern already used for hpc::bitwise, hpc::fft, hpc::fingerprint, hpc::quantized, hpc::cam_pq, and hpc::heel_f64x8 in the same section of simd.rs.

Whole-module alias rather than an item list, so future cascade items surface without further re-export edits. simd and hpc share the identical std feature gate (lib.rs:238 / lib.rs:498), so no additional cfg is needed.

Verification

  • cargo clippy --lib -- -D warnings — green (compiles the re-export, proving path resolution)
  • cargo fmt --check — clean

🤖 Generated with Claude Code

https://claude.ai/code/session_01K3RyLEbuNSHxxB3NTTrGki


Generated by Claude Code

Summary by CodeRabbit

  • New Features
    • Added public access to the cascade search API through the SIMD module.

Consumers under the all-SIMD-from-ndarray::simd invariant need the
Belichtungsmesser surface (Cascade::expose -> Band, recalibrate,
PackedDatabase, adaptive_resolution) without reaching into crate::hpc
directly — the Prozentrang/distribution-shape payload work in the
consumer stack reads exposure bands through this path. Whole-module
alias rather than an item list, so new cascade items arrive without a
re-export edit. Both modules share the identical std feature gate.

cargo clippy --lib -D warnings green; cargo fmt --check clean.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K3RyLEbuNSHxxB3NTTrGki
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e5e41cd-18ec-4bfd-af96-f5f221d48ea6

📥 Commits

Reviewing files that changed from the base of the PR and between bbbab0d and f66449a.

📒 Files selected for processing (1)
  • src/simd.rs

📝 Walkthrough

Walkthrough

The change re-exports crate::hpc::cascade from ndarray::simd::cascade, making the cascade search API available through the SIMD namespace.

Changes

Cascade API exposure

Layer / File(s) Summary
SIMD cascade re-export
src/simd.rs
The cascade module is publicly re-exported under the SIMD namespace.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: claude

Poem

A rabbit hops through SIMD light,
And finds cascade paths just right.
One re-export, neat and small,
Makes the search API available to all.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: re-exporting hpc::cascade through ndarray::simd::cascade.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Aug 5, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_18a85429-31d0-4835-9cc7-c91936602cad)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review August 5, 2026 01:09
@cursor

cursor Bot commented Aug 5, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_e3aa2e8e-f36d-4f95-bd46-9a57be7f99fe)

@AdaWorldAPI
AdaWorldAPI merged commit 417f66a into master Aug 5, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants