Repository navigation
lance-graph-xlog cube: add_relation for derived relations - #1912
Merged
Merged
Conversation
…ube's frame A rule's output or a fixpoint delta enters the cube as one more relation: its ids are looked up once in the shared map, existing relations are not touched, an id outside the map or a stale frame is refused. Needed for recursive and derived-input rules in XLOG's plans. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
…rge) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
November 1, 2026 04:10
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
Cube::add_relation(table, tuples) -> RelId. A rule's output, or a fixpoint delta, enters the cube as one more relation under the cube's existing frame:XLOG's recursive rules and its rules that read derived relations need this. Those are 141 of the 218 rules the cube currently refuses (xlog#2). Recursion follows in xlog#2, using this.
Test
an_added_relation_joins_like_a_base_one:Domain.Map(Stale).Also in this PR
main's generated entries index was stale after the #1909 merge. The index check failed on a cleanmaincheckout, so it is regenerated here.Generated by Claude Code