Repository navigation
contract: mirror OGAR's 0xFFXX hardcoded-behaviour reservation (D-DT64-7 O2) - #1904
Merged
Merged
Conversation
…T64-7 O2) HARDCODED_BEHAVIOUR / HARDCODED_BEHAVIOUR_DOMAIN mirror ogar_vocab (OGAR #365), with a guard that no CODEBOOK row lands in 0xFFXX. The r2il polyfill's HARDCODED now reads the contract constant, so the value has one spelling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
…item Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AdaWorldAPI
marked this pull request as ready for review
November 1, 2026 01:47
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ogar_codebook::HARDCODED_BEHAVIOUR(0xFFFF) andHARDCODED_BEHAVIOUR_DOMAIN(0xFF) mirrorogar_vocab's reservation, which merged in OGAR specs(sprint-5-6): 13-worker parallel batch + Opus meta review (governance only) #365.no_mirrored_row_lands_in_the_hardcoded_behaviour_block:CODEBOOKrow has a high byte of0xFF;hardcoded_behaviour;0xFFFFis stillUnassigned.lance_graph_r2il::polyfill::HARDCODEDnow reads the contract constant, so0xFFFFis spelled in one place.Validation
cargo test -p lance-graph-contract --lib: 1563 passed.cargo test -p lance-graph-r2il: all suites pass.("planted_in_reserved_block", 0xFF01)added toCODEBOOK, the test fails withplanted_in_reserved_block (0xff01) landed in the reserved 0xFFXX block. The file was restored withgit checkout.SUPERSESSION-INDEX.mdwas regenerated and is unchanged.Generated by Claude Code