Repository navigation
D-DT64-7 §1c: label hydration from consumer codebooks to DT64 - #1900
Merged
Merged
Conversation
Answers whether hotplug -> ogar-vocab -> lance-graph-ogar needs planning for labels to reach DT64: yes. Activation carries no field labels; OgarClassView hydrates only OGAR's promoted concepts; DT64 keys a lens's basis by the left half, so every 0xFFFF lens shares one 256-word basis (correcting the 65,536-per-concern claim in §1b) and a consumer's behaviour lens shares its data basis; no view composes the sources. Adds items L1-L5 and decisions O9 (basis key) and O10 (label handover). Also restores the '## 2. The classid, both sides' heading that the §1b commit dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI
marked this pull request as ready for review
October 31, 2026 21:01
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only. This adds the plan section that missed #1898's merge. It edits one file:
.claude/plans/d-dt64-7-behaviour-addressing-registration-v1.md.§1c
Do field labels from a consumer codebook reach DT64 through the
hotplug.rs→ogar-vocab→lance-graph-ogardelegation? Not today. The findings below were checked againstmainatb38d88eand OGAR at2a080a9.H1 — Activation carries no field labels.
Activationholds only concept names, capabilities, read modes and register laws. DT64 reads labels from whateverClassViewthe caller passes, and nothing ties that view to the codebook that activated the concept.H2 —
OgarClassViewcovers only OGAR's promoted concepts. For any other class it returns an empty basis, so a consumer codebook has no way into it.H3 — DT64 keys the label basis by the left half of the classid.
view_classisclassid_concept. As a result:0xFFFFshares one basis of at most 256 words;Domain::AppId::0xF###behaviour lens shares a basis with that consumer's data class.This also corrects the "65,536 words per concern" claim in §1b.
H4 — No
ClassViewcombines OGAR, consumer codebooks and the0xFFFFaliases.H5 — An unknown class fails closed. DT64 refuses it with
FieldBasisChanged(count mismatch), which is correct as it stands.The section also adds:
ClassViewrouted by left side; refuse reads of classes that were not activated; ship the alias views as a library; settle how a consumer hands over its labels.It also restores the
## 2. The classid, both sidesheading, which the §1b commit in #1898 accidentally dropped.Checks
citation_decay --since origin/main: 0 new decays.append_only_gate: OK.Generated by Claude Code