Repository navigation
X2: DT64 execution-admission policy probe (LAB) - #1891
Conversation
A typed policy layered after BindStore::admit: admit authenticates, the policy decides from D-SAG-6 evidence rows whether an admitted method may execute (pure, under an explicit DO grant, or refused as POSSIBLE / UNKNOWN / requiring the DO gate). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
14 guards disabled one at a time against b7cfe93, each red. Board entry records the measured fixture outcomes and the open points (rows are reconstructed, trust list ownership, DoGrant issuer). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed5c536eab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The span join names closure bodies after their enclosing function
(fn::{closure@Lnn}::call_mut) and gives them no DEFINES row, so the
producer's call_once -> call_mut shim call was refused as an unaudited
external callee and every closure-bearing method read UNKNOWN. A callee
nested under a subject already in scope is now treated as in scope; its
rows were already read through the prefix. The fixture gains the shim
rows the producer emits, and two structure tests pin both directions (a
look-alike prefix without the :: boundary, or another function's
closure, stays unaudited).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMNZqKXSaeb9g2ypywF
# Conflicts: # .claude/board/entries/README.md
A lab probe (
crates/dt64-admission-probe, its own workspace, excluded from the root) for the execution-admission policy that sits afterBindStore::admit.admitis unchanged. It still authenticates method id, signature revision and guard witness.ExecutionPolicy::decidecalls it and then classifies the method's D-SAG-6 evidence rows:DEFINESrow; absence of rows is not purity)Admitted::Pure { binding, assumed }DoGrantfor this exactMethodRefAdmitted::UnderDoGrantRequiresDoGate/GrantDoesNotCover/GrantForOtherMethodPossible(a grant never lifts it)Unknown { causes }(never read as false)Precedence: UNKNOWN, then POSSIBLE, then witnessed effect. Evidence attaches to
(class, MethodId, SigRev), never to the method's name.Fixture outcomes:
count_belowruns as pure, but only under a trusted-callee list; without the list it is UNKNOWN.count_with_tallyandcount_divrun only under a covering grant.All 8 fixture methods pass
admit, and only 2 of them run as pure.What changed
crates/dt64-admission-probe, plus its entry in the rootexcludelist.lance-graph-dt64orlance-graph-contract.Validation
cargo test --manifest-path crates/dt64-admission-probe/Cargo.toml: 25 passed, reproduced independently. Clippy-D warningsand fmt are clean.Caveats
src/fixture.rscites each group). They are notproject_rows.pyoutput, because none is committed. Running Charon on the fixture and committing the real TSV would replace them.DoGrant;Plan: D-DYNBAG §18.4 X2 (on #1890, not yet on main). Board entry:
.claude/board/entries/2026-10-31-x2-dt64-admission-policy.md.Generated by Claude Code