Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug outlined in #999.
I ran the full population with activitysim on v1.6 with sandag on latest on main at 68b23d4 successfully using:
Then I applied the bug fix sitting in this pull request (or switched branches in activitysim) and ran again successfully to check that it does not create any errors on a normal run:
Applied
resume_afterto sandag in settings_mp.yaml and ran successfully again with bug fix applied using:Then reverted bug fix back and ran again with fail as documented in #999.
I used Copilot to help me write a simple test too. This is sitting in the pull request too. Under standard review practices for this project, what happens next for review?