Repository navigation
Conversation
The gate battery is green at this commit: ruff check/format, mypy src, pytest 982 passed at 90.99% coverage, and the pinned GNN conformance gate with GNN_ROOT set. The claim_support audit output is byte-identical (behavior-preserving).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prediction
At head
bd99405, the check-set should read exactly two rows, both pass:gates— pass (ruff check, ruff format, mypy, artifact build + provenance gates, pytest --cov=src --cov-fail-under=90)gnn conformance (pinned)— pass (pinned-parser extract + conformance tests)No other workflow-owned rows are expected; this repository has a single workflow (
gates.yml). If GitHub Actions is still billing-locked, both rows will fail in 1-2 s withsteps: 0and the annotation "The job was not started because your account is locked due to a billing issue" — instrument outage, not a verdict on this change.Change
ruff checkis red onmain:SIM102(collapsible nestedif) fires twice in_audit_evidenceinsrc/manuscript/claim_support.py— once for thedeliveryclaim type, once for thevisualclaim type. This collapses the two nested conditionals into theirelifguards:Each branch appends the same issue message the nested form appended, and no
elseexists on either innerif, so the fix is behavior-preserving.Local verification (the repo's own gates, run before opening)
uvx ruff check src scripts tests— 0 diagnostics (was 1 onmain)uvx ruff format --check src scripts tests— 280 files already formatteduv run mypy src— Success: no issues found in 142 source filesuv run pytest --cov=src --cov-fail-under=90 -q— 982 passed, coverage 90.99% (floor 90%)GNN_ROOT=... uv run python scripts/validate_gnn_spec.py— exit 0, receipt checks 6/6 at the pinned commit8f293d9btests/test_claim_support.py— 39/39 passed, includingtest_delivery_row_needs_validatorsandtest_visual_row_missing_figure, which assert the message text and audit outcome of both touched branchesThe regenerated
output/artifacts (PNG byte noise from matplotlib version drift) are left uncommitted.