Repository navigation
Run the pinned GNN conformance checks in CI - #8
Merged
Merged
Conversation
Add a gnn-conformance job that fetches the GNN revision recorded in gnn/upstream.json from the public upstream repository at that exact SHA, provisions its interpreter, runs the strict scripts/validate_gnn_spec.py gate, and runs tests/test_gnn_conformance.py. The conformance tests now fail instead of skipping when GNN_ROOT selects a missing or unusable checkout, so the job cannot pass vacuously. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tests/test_gnn_conformance.pyis the only check that tiesgnn/gaussian_agent.gnn.mdto the parser revision pinned ingnn/upstream.json, but CI never ran it with a GNN checkout: the pinned-parser half skipped and the green run proved nothing about the pin.This adds a
gnn conformance (pinned v5.0.3)job that provisions the pinned revision and runs both the strict validator and the conformance tests. The fixture now fails instead of skipping whenGNN_ROOTselects a missing or unusable checkout, so the job cannot pass vacuously.Modelled on
ActInf_RxInferandActiveBlockference(a separategnn-conformancejob with its own pinned GNN runtime) and onGEN24/active_inference_power(fetch the pinned tree at the recorded SHA and validate against it).What changed
.github/workflows/ci.yml— newgnn-conformancejob. It fetches8f293d9b…(tagv5.0.3) from the public upstream repository at that exact SHA, checks out detached, creates.venvinside the checkout withnumpyanddefusedxml(what the pinned extractor needs), then runspython scripts/validate_gnn_spec.pyandpython -m pytest tests/test_gnn_conformance.py -q. A pin that no longer resolves fails atgit fetchinstead of skipping. Actions are pinned by SHA, reusing the SHAs the repository already uses.tests/test_gnn_conformance.py— theextracted_modelfixture now fails (pytest.fail) whenGNN_ROOTis set but the pinned parser is unavailable, and skips only whenGNN_ROOTis unset. Docstring updated.AGENTS.md— notes that CI runs both commands against the pinned revision.Negative tests: the new check can fail
Every mutation was made in a scratch copy and reverted; nothing is committed.
Baseline against a checkout of the pinned revision:
scripts/validate_gnn_spec.pyexit 0 (printing the four conformance checks) and10 passed.gnn/upstream.jsoncommitset to8b864ae68dd20527479f2901174c9864d56f3c04(upstreammaintip) and fetched into a scratch checkout, so the fetch itself succeeds:Qdiagonal0.5→0.25ingnn/gaussian_agent.gnn.md:GNN_ROOTpointing at a missing directory now errors instead of skipping:git fetch --depth 1 origin <sha>exits 128 (upload-pack: not our ref), so the job stops before the validator runs.Verification
actionlintclean on the edited workflow.10 passed.I will not merge this until the new job is green here.