Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/webpack.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: NodeJS with Webpack

on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18.x, 20.x, 22.x]

steps:
- uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Build
run: |
npm install
npx webpack

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Wrong Bundler Command

When this workflow runs on a push or pull request to main, npx webpack does not match the repository build path. The project installs Rspack tooling and the existing build script runs Rspack, so this job can fail on the missing local webpack CLI or validate an unpinned tool instead of the intended build.

Suggested change
npx webpack
npm run build


2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"@rspack/core": "^2.0.0",
"@types/ace": "^0.0.52",
"@types/cordova": "^11.0.3",
"@types/node": "^26.1.0",
"@types/url-parse": "^1.4.11",
"autoprefixer": "^10.5.0",
"babel-loader": "^10.1.1",
Expand Down Expand Up @@ -110,6 +111,7 @@
"terminal": "^0.1.4",
"ts-loader": "^9.5.7",
"typescript": "^5.9.3",
"vscode-languageserver-protocol": "3.18.2",
"vscode-languageserver-types": "^3.17.5",
"ws": "^8.21.0"
},
Expand Down
4 changes: 4 additions & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
allowBuilds:
'@parcel/watcher': true
core-js: true
core-js-pure: true
3 changes: 3 additions & 0 deletions src/lang/en-us.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
"editor theme": "Editor theme",
"enter file name": "Enter file name",
"enter folder name": "Enter folder name",
"enter new name": "Enter new name",
"new name": "New name",
"code actions": "Code Actions",
"empty folder message": "Empty Folder",
"enter line number": "Enter line number",
"error": "Error",
Expand Down
3 changes: 3 additions & 0 deletions src/lang/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ declare type LangStrings = {
"editor theme": string;
"enter file name": string;
"enter folder name": string;
"enter new name": string;
"new name": string;
"code actions": string;
"empty folder message": string;
"enter line number": string;
"error": string;
Expand Down