OTIO import: map ImageSequenceReference clip trims into media frame space - #324
Open
soupkitchenfilms wants to merge 1 commit into
Open
Conversation
…pace
xSTUDIO clip active ranges are media-native file frames, but OTIO
source_range is expressed in the media reference's available_range space.
Conforms anchored to absolute timecode (EDL/CSV-derived OTIOs where
available_range.start_time is the timecode-as-frames of the first file
frame) imported with trims ~1.2M frames outside the media — every clip
displayed the wrong frames and cross-track record sync was lost.
Re-anchor ImageSequenceReference trims through start_frame:
trim = start_frame + (source_start - available_start)
This collapses to the previous verbatim behaviour whenever
available_start == start_frame (xSTUDIO/NLE exports), and rescues
timecode-anchored conforms. Verified frame-exact against a 25-clip
4-track production conform (record positions and cut-in frames match the
generating lineup).
Signed-off-by: soupkitchenfilms <13426391+soupkitchenfilms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xSTUDIO clip active ranges are media-native file frames, but OTIO
source_rangeis expressed in the media reference'savailable_rangespace. Conforms anchored to absolute timecode (EDL/CSV-derived OTIOs whereavailable_range.start_timeis timecode-as-frames) import with trims ~1.2M frames outside the media — every clip shows wrong frames and cross-track record sync is lost.This maps ImageSequenceReference trims through
start_frame:Identity whenever
available_start == start_frame(xSTUDIO/NLE-authored OTIO), so existing behaviour is preserved; timecode-anchored conforms become frame-exact. Verified against a 25-clip, 4-track production conform (cut-in frames and record positions match the generating lineup exactly).Happy to add a unit test if you can point me at the preferred harness for timeline import.
Supersedes #308, re-based onto
develop(process_itemmoved but still appliessource_range->start_time()verbatim, so the mis-anchoring persists there).