Python OTIO reader: clip_if() no longer exists in bundled OTIO 0.18 - #323
Open
soupkitchenfilms wants to merge 1 commit into
Open
Conversation
…ps() The bundled opentimelineio is 0.18.1, where Timeline.clip_if() no longer exists (find_clips() replaced it in 0.15), so import_timeline() raised AttributeError on every use. Also guard media references that carry no target_url (e.g. ImageSequenceReference) instead of crashing on attribute access. Signed-off-by: soupkitchenfilms <13426391+soupkitchenfilms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api/auxiliary/otio/reader.pycallsotio.clip_if(), which was removed from OpenTimelineIO (find_clips()replaced it in 0.15). With the bundled otio 0.18.1 the python-side timeline import raisesAttributeErroron every use.Also guards media references that carry no
target_urlattribute (e.g.ImageSequenceReference) — previously the next line would raiseAttributeErroron those clips.Supersedes #309, re-based onto
develop(same one-commit fix; the bug is still present there —reader.pyline 95).