fix: SG-44428: Fix text cursor - #1360
Merged
eloisebrosseau merged 1 commit intoAug 21, 2026
Merged
Conversation
eloisebrosseau
force-pushed
the
fix-text-cursor
branch
from
July 22, 2026 21:26
b67b4b5 to
ee86207
Compare
eloisebrosseau
force-pushed
the
fix-text-cursor
branch
2 times, most recently
from
August 10, 2026 15:17
ee86207 to
9296b0f
Compare
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
eloisebrosseau
force-pushed
the
fix-text-cursor
branch
from
August 20, 2026 13:17
9296b0f to
fe09370
Compare
eloisebrosseau
marked this pull request as ready for review
August 20, 2026 13:45
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
August 20, 2026 13:45
cedrik-fuoco-adsk
approved these changes
Aug 21, 2026
eloisebrosseau
merged commit Aug 21, 2026
794fd78
into
AcademySoftwareFoundation:main
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: SG-44428: Fix text cursor
Summarize your change.
This PR adds a few missing session events the annotation package needs to listen on to commit the text annotations and remove the cursor that is displayed on the frame while typing. The method
on_text_commitis passed as a lambda to know if the event needs to be consumed (i.e. hotkeys) or not (i.e. session events) before committing the text annotations.Describe the reason for the change.
When saving a session after adding text annotations, the "|" indicating where the cursor is on the screen was still being kept as part of the annotations. This caused the symbol to be shown when reloading the session file previously saved.
Describe what you have tested and on which operating system.
Adding text annotations, saving the session file, and reloading the session file to validate that the text cursor is not displayed on the frame anymore was tested on macOS.