Fix RTD logo - added on subpages and change logo to magenta - #2338
Open
Danb106632 wants to merge 1 commit into
Open
Fix RTD logo - added on subpages and change logo to magenta#2338Danb106632 wants to merge 1 commit into
Danb106632 wants to merge 1 commit into
Conversation
Closes AcademySoftwareFoundation#2036 - fixed double ../ on subpages due to pathto() computing another relative path on top of page-relative image path Signed-off-by: Danb106632 <daniel.beeching3@gmail.com> - Changed logo fill colour to #cc1e68 so it is visible both light and dark mode Signed-off-by: Danb106632 <daniel.beeching3@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by building sphinx-press-theme and navigating through pages, verifying visibility.
Fixes #2036