test: add Playwright coverage and test ids for CpsTreeAutocompleteComponent - #844
Open
fateeand wants to merge 2 commits into
Open
test: add Playwright coverage and test ids for CpsTreeAutocompleteComponent#844fateeand wants to merge 2 commits into
fateeand wants to merge 2 commits into
Conversation
fateeand
requested review from
TerranceKhumalo-absa,
korel-san and
lukasmatta
as code owners
August 12, 2026 14:42
Contributor
Coverage report for library
Test suite run success2474 tests passing in 76 suites. Report generated by 🧪jest coverage report action from 26fe9fe |
Contributor
Playwright test resultsDetails
|
…-playwright-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hideDetails,openOnClear=false, real typing filters the tree, Enter confirms typed text (exact match / no-match revert), customemptyMessagerendering, clicking the box moves real focus to the input and visually hides the selected-label span (real computed-opacity assertion),expandAll()/collapseAll().hideDetails,openOnClear=false,ariaLabel-only,expandAll/collapseAlland customemptyMessage.CpsTreeAutocompleteAppearanceType.(mousedown)handler only calledpreventDefault(), notstopPropagation(). Since the box wrapper listens on(mousedown)="onBoxClick()", the mousedown still bubbled up and unconditionally reopened the dropdown completely bypassingopenOnClear=false.expandAll()/collapseAll()mutatedTreeNode.expandedin place but never told PrimeNG'sp-tree(which isOnPush) to re-render, so the DOM silently never reflected the call.TODO: Merge with
feat: add test ids to tree autocomplete component and fix openOnClear behaviorRelease notes: