Skip to content

fix(portal): reserve the steward hint height in the new-project dialog - #4594

Merged
vybe merged 1 commit into
Abilityai:devfrom
pcbeingused333:fix/4514-steward-hint-height
Nov 17, 2026
Merged

vybe merged 1 commit into
Abilityai:devfrom
pcbeingused333:fix/4514-steward-hint-height

Conversation

@pcbeingused333

Copy link
Copy Markdown
Contributor

Fixes #4514

Description

The new-project dialog changed height when the steward changed. The skills hint under Steward reserved two lines (min-h-[2.5rem], 40px). text-xs is a 1rem line, so that floor holds two lines of text. The longest hint, the server's set.message when the project-management skills are not on this Trinity, wraps to three lines (48px) at the dialog's desktop width and four lines (64px) at 390px. The "You" line is two lines at desktop and three at 390px. Switching You and an agent therefore moved the dialog by 8px at 1440px and 16px at 390px. Switching "Who can see it" already keeps its height (#3565); this was a separate line.

The hint now reserves four lines below the sm breakpoint (min-h-[4rem]) and three from sm up (sm:min-h-[3rem]). The panel is w-full max-w-lg inside an overlay with p-4, so from 544px of viewport it is already at the desktop width, and sm (640px) is past that point. The floor is on the element before the steward-options read returns, so the message arriving does not grow the dialog either.

Choosing "Someone else…" still opens the email field. That field is how a person steward is named. The skills hint itself stays one height for You, someone else, and an agent, with the skills set available or not.

Related Issue

Fixes #4514

Journey Impact

Journey Impact: none: the skills hint keeps a reserved height; no journey promise changes

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

  • I have tested this locally
  • New tests added (if applicable)
  • All existing tests pass
  • Every new test executes the changed path

#4514 in tests/unit/projectStewardHint4514.mount.spec.js mounts the dialog and reads the rendered hint. jsdom does not lay out, so the floor is the class contract, as with the agent-header row. The hint must carry min-h-[4rem] and sm:min-h-[3rem], and not the old min-h-[2.5rem], while the options read is still pending and after it resolves with the skills set available and unavailable. Switching Steward between You, Someone else, and an agent keeps that same element and those classes, and the visible sentence follows the steward.

Before the class change those three tests failed on the missing min-h-[4rem]. After it they pass. The existing steward-hint mounts (workspaceProjectsEnt1169.mount.spec.js, 17) and the visibility-height mounts (workspaceProjectsReleaseFixes.mount.spec.js, 6) also pass.

The reservation does not depend on theme. The hint already uses the light and dark text colors; this change does not add a theme branch.

Mutation: restoring min-h-[2.5rem] and dropping the two new classes makes the three #4514 tests fail. With the classes restored they pass.

Checklist

  • My code follows the project's style guidelines
  • I have updated the documentation (if applicable)
  • I have not committed any sensitive data (API keys, credentials, etc.)
  • I have added appropriate logging for new functionality

Prepared with AI assistance.

Abilityai#4514)

The skills hint reserved two lines (min-h-[2.5rem], 40px). The longest hint, the server's set.message, wraps to three lines at the dialog's desktop width and four at 390px, so switching the steward resized the dialog. Reserve four text-xs lines below sm and three from sm up, when the panel is already at max-w-lg.
@vybe

vybe commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

merge-train (2026-11-17): on the train as is. Validated at 22b709fbf. Ruling recorded on #4514: the criterion covers the hint line only, so this closes the issue. Notes, not blocking: the spec pins the floor classes rather than a measured height (hiding the hint or enlarging its text leaves it green), and the fixed floor is exceeded by long agent names at 390px and by the server-supplied message at 320px — outside the issue's two widths, but the same class of shift.

@vybe vybe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-train: batch validated on train/20261117-1746 (#4626)

@vybe
vybe merged commit 7ad9955 into Abilityai:dev Nov 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants