Repository navigation
fix(portal): reserve the steward hint height in the new-project dialog - #4594
Merged
Merged
Conversation
Abilityai#4514) The skills hint reserved two lines (min-h-[2.5rem], 40px). The longest hint, the server's set.message, wraps to three lines at the dialog's desktop width and four at 390px, so switching the steward resized the dialog. Reserve four text-xs lines below sm and three from sm up, when the panel is already at max-w-lg.
2 tasks
Contributor
|
merge-train (2026-11-17): on the train as is. Validated at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4514
Description
The new-project dialog changed height when the steward changed. The skills hint under Steward reserved two lines (
min-h-[2.5rem], 40px).text-xsis a 1rem line, so that floor holds two lines of text. The longest hint, the server'sset.messagewhen the project-management skills are not on this Trinity, wraps to three lines (48px) at the dialog's desktop width and four lines (64px) at 390px. The "You" line is two lines at desktop and three at 390px. Switching You and an agent therefore moved the dialog by 8px at 1440px and 16px at 390px. Switching "Who can see it" already keeps its height (#3565); this was a separate line.The hint now reserves four lines below the
smbreakpoint (min-h-[4rem]) and three fromsmup (sm:min-h-[3rem]). The panel isw-full max-w-lginside an overlay withp-4, so from 544px of viewport it is already at the desktop width, andsm(640px) is past that point. The floor is on the element before the steward-options read returns, so the message arriving does not grow the dialog either.Choosing "Someone else…" still opens the email field. That field is how a person steward is named. The skills hint itself stays one height for You, someone else, and an agent, with the skills set available or not.
Related Issue
Fixes #4514
Journey Impact
Journey Impact: none: the skills hint keeps a reserved height; no journey promise changes
Type of Change
Testing
#4514intests/unit/projectStewardHint4514.mount.spec.jsmounts the dialog and reads the rendered hint. jsdom does not lay out, so the floor is the class contract, as with the agent-header row. The hint must carrymin-h-[4rem]andsm:min-h-[3rem], and not the oldmin-h-[2.5rem], while the options read is still pending and after it resolves with the skills set available and unavailable. Switching Steward between You, Someone else, and an agent keeps that same element and those classes, and the visible sentence follows the steward.Before the class change those three tests failed on the missing
min-h-[4rem]. After it they pass. The existing steward-hint mounts (workspaceProjectsEnt1169.mount.spec.js, 17) and the visibility-height mounts (workspaceProjectsReleaseFixes.mount.spec.js, 6) also pass.The reservation does not depend on theme. The hint already uses the light and dark text colors; this change does not add a theme branch.
Mutation: restoring
min-h-[2.5rem]and dropping the two new classes makes the three#4514tests fail. With the classes restored they pass.Checklist
Prepared with AI assistance.