Repository navigation
feat(projects): project mode — Track / Propose / Auto, Start and Stop (enterprise#1235) - #4496
Conversation
…ks for people (abilityai/trinity-enterprise#1232) - statusEnum gains `todo` (the new default); `list_project_tasks` takes `view: "next"` as its own query parameter, never a status. - `create_project_task` takes `status`, `parent`, `blocked_by`, `for_person`; `update_project_task` takes `parent` (null clears it), `blocked_by_add`, `blocked_by_remove`, `for_person`. Ids are T-NNN, lists capped at 20 as the backend caps them. - Descriptions name the rules and the named refusals; each stays under 2,048 characters, asserted for every project tool in projects.test.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ing and tasks for people (abilityai/trinity-enterprise#1232)
- projectsUtils: `todo` ("To do") leads the status list; a subtask sorts
under its parent; helpers name the creator, who a task is for, subtask
progress and "Waiting on T-NNN" (derived, never the Blocked status);
shape refusals map to the parent / waits-on fields.
- ProjectTasks: rows nest subtasks and show progress, the wait, the
assignee and the creator; the detail adds created by / subtask of /
subtasks / waits on; a task for a person offers no Start. The form edits
the parent (blank sends null) and the tasks it waits on as add/remove;
create takes parent, waits on and "a person does this task".
- workspace-projects.md: the same rules in the words the agent tools use.
Tests: workspaceProjectsEnt1232.mount.spec.js (11, mounted); the V2 utils
status pin now includes todo.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…p a dead error mapping (abilityai/trinity-enterprise#1232) - Guide: the switch that makes a task a person's is on the create form only. - projectsUtils.js: remove the invalid_parent field mapping; the backend never sends that code (a malformed id is parent_not_found). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ity-enterprise#1235, C)
Checkpoint C of trinity-enterprise#1235.
- New tool start_project_task(project_id, task_id, agent) → {state:
started|proposed, run} or a structured refusal with its code. It posts to
the agent run route with the turn id and a deterministic Idempotency-Key
derived from the arguments (Invariant #18). The description (< 2048 chars)
names the three modes, the refusals and how a run ends.
- access.ts policy row; MCP doc tool count 179 → 180 (projects.ts 15 → 16).
- Tests: projects.test.ts (key determinism, refusal shape, client route and
headers, description words, the 2048 cap).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… page (trinity-enterprise#1235, D) The project page reads the lifecycle and the mode the platform now enforces: - ProjectPage: a state badge (Not started / Running / Stopped / Done / Archived) with who changed it and when; Start project / Stop project and Mark done for edit rights; the mode (Track / Propose / Auto) as a selector for edit rights and a read-only badge for everyone else; Stop asks first and names the runs still finishing (or says runs under way finish when the read carries no list); a banner on a stopped project, which also says a message in an existing task chat still reaches its agent (T8). - ProjectRunsWaiting (new): in Propose and Auto, the proposed runs with checkboxes, Approve selected and Decline (optional note), one outcome per id in words, and "Nothing is waiting for your go" when empty. - ProjectTasks / ProjectTaskStart: the "Needs my go" toggle (sends needs_go, keeps unsaved form edits), "Needs a go" on a held row, needs a decision with the steward's last reason, the live run on the row and in the detail, and on a project that isn't running the reason in place of Start. A refused Start names its refusal (task_run_live, project_stopped, ...). - projectsUtils: state, mode and run labels with a tolerant fallback; an unknown status or mode reads "Unknown" and offers no lifecycle verb. The stored-status labels now read Running / Stopped / Not started everywhere (list, rail, page). - Store: startProject, stopProject, setMode, fetchRunsWaiting, decideRuns. - User guide: the lifecycle and what each state does to agents, the three modes, the steward's own schedule versus platform wakes, held tasks and the two-rejection rule, the open-task-chat gap, and start_project_task in the words of its MCP description. Tests: new workspaceProjectsEnt1235.mount.spec.js (24, mounted) and two store-route tests in workspaceProjectsStore.spec.js. Mutation: making an unknown status read as running, and Stop skipping its confirm, turned 2 tests red; restored. workspaceProjectsUtils.spec.js now pins Stopped for paused. Release note: Paused now means Stopped, and a stopped project refuses new task runs (before, Paused did nothing to agents). A new project begins as Not started; existing projects keep running. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… done (trinity-enterprise#1235, I-3)
lifecycleActions read only the state, so a project whose mode the page does
not know (a newer backend value) still offered Start/Stop/Mark done while its
label read Unknown. It now offers nothing unless the mode is one of
PROJECT_MODES (a project read without a mode is still Track).
Tests: the helper with {mode:'turbo'} on a running project, and a jsdom mount
of the project page with the same; both red before the change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
/validate-pr — #4496 @26a27c7c58 — REQUEST CHANGES (paired)Validated against the stacked base The code in this PR is fine. It is held because its paired backend PR has a blocking defect, and the two merge together. A task run that has finished is never closed on the backend. That has two visible effects here:
No change to this PR's code is needed for that fix. Details are on the paired PR.
Not run: the evidence-sweep suites (already run), backend unit and CodeQL (they run at retarget), and UI verification (after merge). |
/validate-pr round 2: #4496 @26a27c7c58. Decision: APPROVE (paired)I validated against the stacked base
Not run here: suites already run in round 1. |
|
Chain note (trinity-pm): |
…nd shows it (abilityai/trinity-enterprise#1232)
Operator ruling 2026-11-12 ("Unblock, flag, require a note").
- MCP: update_project_task's note is required for that transition; its
description and list_project_tasks' say what `closed_without_claim` and
`blockers_closed_without_claim` mean ("its output may not exist; read the
note"). A refusal surfaces as done_without_claim_needs_note.
- Page: setting done on a task with an agent on it, from anything but
awaiting verification, makes the note required and sends nothing without
it. The server's refusal shows under the note. The row and the detail show
the flag, and a dependent names the blocker.
- Guide: one paragraph under the verification rule.
Awaiting verification → done and tasks for a person are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts in ProjectTasks.vue and projectsUtils.js resolved keeping both:
the trinity-enterprise#957 board view and abilityai/trinity-enterprise#1232's
task shape.
The board now shows the task shape correctly:
- `todo` is named by the first (Active) column and flagged "To do"; it was
previously a known status there, so it read as Active with no badge.
- A card shows derived waiting ("Waiting on T-2") and subtasks beside the
Blocked status's waiting_on line.
- A done card closed without its agent's claim carries the
"Done without a done claim" badge.
- Dropping a card on Done from anything but pending-verification already
asks for the note the server requires.
Board specs: the "status the board does not know" cases used `todo` as
the unknown stand-in; they now use `triage`, and new cases pin todo,
waiting and closed-without-claim (reverting the projectsUtils change
turns 3 of them red).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts resolved keeping both intents: - src/mcp-server/src/tools/projects.ts: #4490's shared createTaskParams / updateTaskParams + declared() filter now carry every ent#1232 param (todo status, parent, blocked_by, blocked_by_add/remove, for_person, the done-without-claim note); both descriptions carry the ent#1232 rules and REFS_RULE, each under 2048 chars. - projects.test.ts: both describe blocks kept; the ent#1240 "drops undeclared keys" case uses priority (status is declared on create now). - workspace-projects.md: both sections (GitHub issues and PRs before Subtasks, waiting and tasks for people). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in ent#1232's done-without-claim display and ent#1240's task refs and board view. Both intents kept: - projectsUtils: the lifecycle/mode/run helpers beside the ref badges. - stores/projects: start/stop/mode/runs-waiting verbs beside moveTask and the ref verbs. - ProjectTasks: the needs-a-go and live-run badges beside "Done without a done claim"; the needs-decision line, live run and Needs-my-go toggle beside the unclaimed lines; one import list. - Store spec and MCP projects tests: both suites kept. MCP: ent#1235 adds no create/update shape param (needs_go is a person's, so no tool sets it); start_project_task forwards only its named fields. Every project tool description is under 2048 characters (max 1406); the start_project_task description test now asserts the bound. Tool count in docs stays 180 / projects.ts 16 for this tree (ent#1237's four file tools are on dev, not on the 1232 tip). Submodule pin: 888233b (ent main), as on the 1232 branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
/validate-pr — delta round 3 (fix-4) — run chain-ent1232-1235-validate-3Range: 26a27c7..83b9d62 (merge of the 1232 tip a0a9783). Paired: abilityai/trinity-enterprise#1252 @ 9b92e77c7b, delta APPROVE.
Recommendation: REQUEST CHANGES (PR body only, no code change). This PR requires the following changes before merge:
The code delta is approved. Editing the body does not push anything, so remove 🤖 Generated with Claude Code |
|
Chain note (trinity-pm): the one change requested in validate round 3 is done. The body line now reads All four PRs in this chain now leave draft together. Merge order is the operator's call: ent #1249 → #1252, and trinity #4493 → #4496. |
Conflicts, both docs: mcp-server.md tool counts (183 on dev + start_project_task = 184 tools, 179 operator; projects.ts 16, platform_files.ts row kept) and workspace-projects.md (dev's steward-waking bullet plus this branch's stopped-project chat bullet). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The squash adds only the 1232 tip a0a9783, which this branch already contains, so the tree is unchanged by this merge. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
dev's wake paragraph (#4491) said the steward starts no task runs in a wake turn; with project mode a Propose or Auto project lets it propose or start one. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
What
The open-source half of project mode (Track / Propose / Auto, with Start and Stop). The backend half lives in the enterprise module, on the same branch name
feature/1235-project-mode.start_project_tasklets the project's steward propose or start a task run. Tool count is now 180.access.tsandclient.tsare wired for it, andprojects.test.tscovers it.runs_live. A newProjectRunsWaitinglists proposals waiting on a person, with batch approval.ProjectTaskStartgives the go on a held task.projects.jsandprojectsUtils.js(mode, lifecycle actions).workspace-projects.md(modes, Start/Stop) andmcp-server.md(the new tool, 180).Stacked on
feature/1232-task-shape(#4493), so this PR's base is that branch.Fixes abilityai/trinity-enterprise#1235 (cross-tracker: the issue's status is set by hand after merge).
Journey Impact
Journey Impact: extends: J22
Review + security
26a27c7c58: an unknown mode offers no lifecycle actions, tested with{mode:'turbo'}. The MCP tool's description states only behaviour that is built.Tests
workspaceProjectsEnt1235.mount.spec.js(new, 25 tests),workspaceProjectsStore.spec.js,workspaceProjectsUtils.spec.js,tools/projects.test.ts.Before merge
Stack: this PR merges after feat(projects): task shape — subtasks, waits-on, not started, tasks for people #4493. Retarget it to
devonce feat(projects): task shape — subtasks, waits-on, not started, tasks for people #4493 lands. While its base is a feature branch, its CI is partial (no backend unit run, no CodeQL), so the full run happens at retarget.Conflicts this branch adds, beyond feat(projects): task shape — subtasks, waits-on, not started, tasks for people #4493's:
access.ts,client.ts,tools/projects.tsmcp-server.md(tool count)projectsUtils.jsworkspace-projects.mdThe merge order is the operator's call.
It merges together with the paired enterprise PR. The submodule pin moves at merge, not here.
🤖 Generated with Claude Code