Skip to content

fix(operator-queue): sync-health alert rows keep the seen line and alert expiry wording (#4139) - #4462

Merged
vybe merged 1 commit into
Abilityai:devfrom
ericdelorefice:fix/4139-queue-seen-line
Nov 17, 2026
Merged

vybe merged 1 commit into
Abilityai:devfrom
ericdelorefice:fix/4139-queue-seen-line

Conversation

@ericdelorefice

Copy link
Copy Markdown
Contributor

Description

Per #4139, #4016 kept the sync health rows on their own type (sync_failing, sync_diverged, git_bloat) for the filter, stats and label, but queueSeenLine and queueEnding in src/frontend/src/utils/operatorQueue.js still checked type === 'alert'. So a re read sync_failing row showed no "seen N times" line, and an expired one said "nobody answered in time" instead of "nobody acted on it".

I added a small isPlatformAlert(item) helper that is true for type === 'alert' or a row with a subject, and both spots use it. The row type stays as it is. I keyed on subject and not seen_count because only the platform alert seam writes a subject (create_platform_item), and agent asks and gates never carry one (db/tables.py:1648), the backend already ranks platform alerts by subject.isnot(None) at db/operator_queue.py:1685.

Since the issue asked about other kinds with their own row type, this also gives the seen line and alert wording to the budgeted kinds (queue_flood, skill_not_found, effect_unguarded, gitignore_untracked, workspace_problem_report), they go through the same seam with a subject. An event kind would have no subject and would still need type === 'alert', there are none in this repo today.

Related Issue

Fixes #4139

Journey Impact

Journey Impact: none: frontend wording for platform alert rows; no journey in tests/journeys/catalog.yaml covers the operator queue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

New tests are in tests/unit/platformAlertSurfaces.spec.js, next to the #3246 ones:

  1. QueueCard mounted with a sync_failing row seen 3 times shows the seen line.
  2. ResolvedCard mounted with an expired sync_failing row says "nobody acted on it".
  3. QueueItemDetail mounted shows the seen line for a re read sync_failing row and "nobody acted on it" for an expired one.
  4. /m (MobileAdmin) mounted with both rows shows the seen line and the expired card says "nobody acted on it".
  5. sync_diverged, git_bloat and queue_flood rows get the seen line and alert: true from queueEnding.
  6. a question row with seen_count 2 but no subject keeps "nobody answered in time" and no seen line. This one passes before and after, it is there so keying on seen_count alone would fail it.

On Node 24 from src/frontend: npx vitest run 528 files, 7910 passed. npm run check:tokens OK and npm run build OK.

Mutation: with operatorQueue.js put back to dev (copied from git show, then the fixed file copied back and checked with shasum), 7 of the new tests go red, twice each: all of 1 to 5 above. 6 stays green.

Checklist

  • My code follows the project's style guidelines
  • I have updated the documentation (if applicable)
  • I have not committed any sensitive data (API keys, credentials, etc.)
  • I have added appropriate logging for new functionality

…ert expiry wording

Since Abilityai#4016 the sync_failing, sync_diverged and git_bloat rows keep their
own row type, so queueSeenLine and queueEnding, which keyed on
type === 'alert', dropped the "seen N times" line and said "nobody
answered in time" when one expired. Both now treat a row with a subject
(the platform alert's condition key) as an alert too.

Fixes Abilityai#4139

@vybe vybe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-train: batch validated on train/20261117-1746 (#4626)

@vybe
vybe merged commit 5bbc3a6 into Abilityai:dev Nov 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants