Repository navigation
fix(operator-queue): sync-health alert rows keep the seen line and alert expiry wording (#4139) - #4462
Merged
Conversation
…ert expiry wording Since Abilityai#4016 the sync_failing, sync_diverged and git_bloat rows keep their own row type, so queueSeenLine and queueEnding, which keyed on type === 'alert', dropped the "seen N times" line and said "nobody answered in time" when one expired. Both now treat a row with a subject (the platform alert's condition key) as an alert too. Fixes Abilityai#4139
ericdelorefice
marked this pull request as ready for review
November 11, 2026 06:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per #4139, #4016 kept the sync health rows on their own type (
sync_failing,sync_diverged,git_bloat) for the filter, stats and label, butqueueSeenLineandqueueEndinginsrc/frontend/src/utils/operatorQueue.jsstill checkedtype === 'alert'. So a re readsync_failingrow showed no "seen N times" line, and an expired one said "nobody answered in time" instead of "nobody acted on it".I added a small
isPlatformAlert(item)helper that is true fortype === 'alert'or a row with asubject, and both spots use it. The row type stays as it is. I keyed onsubjectand notseen_countbecause only the platform alert seam writes a subject (create_platform_item), and agent asks and gates never carry one (db/tables.py:1648), the backend already ranks platform alerts bysubject.isnot(None)atdb/operator_queue.py:1685.Since the issue asked about other kinds with their own row type, this also gives the seen line and alert wording to the budgeted kinds (
queue_flood,skill_not_found,effect_unguarded,gitignore_untracked,workspace_problem_report), they go through the same seam with a subject. An event kind would have no subject and would still needtype === 'alert', there are none in this repo today.Related Issue
Fixes #4139
Journey Impact
Journey Impact: none: frontend wording for platform alert rows; no journey in tests/journeys/catalog.yaml covers the operator queue
Type of Change
Testing
module under test unless its live consumer is CI itself (a workflow, a vendored copy, a
route table), and no bound check at the one value where both bounds coincide (bug(process): tests that assert source TEXT instead of executing the path — three green-CI ejections in one train, third run running #2829)
New tests are in
tests/unit/platformAlertSurfaces.spec.js, next to the #3246 ones:QueueCardmounted with async_failingrow seen 3 times shows the seen line.ResolvedCardmounted with an expiredsync_failingrow says "nobody acted on it".QueueItemDetailmounted shows the seen line for a re readsync_failingrow and "nobody acted on it" for an expired one./m(MobileAdmin) mounted with both rows shows the seen line and the expired card says "nobody acted on it".sync_diverged,git_bloatandqueue_floodrows get the seen line andalert: truefromqueueEnding.seen_count2 but no subject keeps "nobody answered in time" and no seen line. This one passes before and after, it is there so keying onseen_countalone would fail it.On Node 24 from
src/frontend:npx vitest run528 files, 7910 passed.npm run check:tokensOK andnpm run buildOK.Mutation: with
operatorQueue.jsput back todev(copied fromgit show, then the fixed file copied back and checked with shasum), 7 of the new tests go red, twice each: all of 1 to 5 above. 6 stays green.Checklist