Repository navigation
fact_extract: save under the default user id, not a personal name - #448
Merged
Merged
Conversation
skills/fact_extract.py stored each learned fact's conversation row with user_id="mickael", a personal name in the public repo, while every other memory write uses the default id. It now uses the default. Skill manifest regenerated. The 13 existing rows on the owner's Mac were moved to the default id separately, after a backup of memory.db. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
skills/fact_extract.pysaved each learned fact's conversation row withuser_id="mickael"(a personal name in the public repo); every other memory write uses the default id. Mickael (7 Oct): "Switch and move rows". It now uses the default id. Skill manifest regenerated (tools/generate_skill_manifest.py --write). Known issue marked fixed.The 13 existing rows in the owner's
~/.codec/memory.dbare moved to the default id on the Mac, after a backup (not part of this PR; the update trigger keeps search in sync).Checks
tests/test_learning.py: the saved row carries no user id (default); negative control on main's skill: fails. Manifest--checkok, skill imports pass, ruff clean.Deploy
Restart
codec-dashboardandopen-codec.codec-mcp-httpandcodec-agent-runnerkeep the old manifest until restarted, so their firstfact_extractcall is refused until then.🤖 Generated with Claude Code