Call a hybrid function cast from a plain function directly - #322
Merged
Merged
Conversation
…ically-null `this`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Casting a plain function value (e.g. an address from
GetProcAddress) to a function type produces a hybrid function whosethisis a literal null. Every call through it was still lowered to a runtimethistest with two call paths and aphi, at every optimization level. The dead path even called the plain function with an extraptr nullargument.Fix
SimplifyIndirectCallWithKnownCalleenow handles a callee defined byts.CastfromFunctionTypetoHybridFunctionType: it calls the cast's input directly and erases the cast if it is unused.--opt, so--opt_level=0/--dibuilds benefit.LowerToAffineturns calls insidetryintots.Invoke, so one pattern covers both call and invoke; no LLVM lowering changes.Result at
--opt_level=0:%2 = call double @add1(double 4.1e+01).Design notes and rejected alternatives:
docs/hybrid-func-null-this-call-optimization.md.Tests
00funcs_hybrid_null_this.ts: direct call, call insidetry, and a bound method through a function-typed variable. Registered as compile, jit and rc/none corpus; all 6 pass.gc-shared-auto/gc-defaultlib-collectorfailures (--emit=dllexits 0x80000003) reproduce with this change reverted.🤖 Generated with Claude Code